* [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
@ 2024-07-15 23:03 Florian Klink
2024-07-15 23:19 ` Florian Fainelli
2024-07-16 17:47 ` Florian Fainelli
0 siblings, 2 replies; 7+ messages in thread
From: Florian Klink @ 2024-07-15 23:03 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Ray Jui, Scott Branden, Broadcom internal kernel review list,
devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
Cc: Florian Klink
HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
This fixes HDMI hotplug/output detection.
See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
Signed-off-by: Florian Klink <flokli@flokli.de>
---
arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
index 72d26d130efa..85f54fa595aa 100644
--- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
@@ -77,7 +77,7 @@ &gpio {
};
&hdmi {
- hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
+ hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
status = "okay";
};
--
2.45.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
2024-07-15 23:03 [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin Florian Klink
@ 2024-07-15 23:19 ` Florian Fainelli
2024-07-15 23:20 ` Florian Fainelli
2024-07-16 5:30 ` Stefan Wahren
2024-07-16 17:47 ` Florian Fainelli
1 sibling, 2 replies; 7+ messages in thread
From: Florian Fainelli @ 2024-07-15 23:19 UTC (permalink / raw)
To: Florian Klink, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, devicetree,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren
+Stefan,
On 7/15/24 16:03, Florian Klink wrote:
> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>
> This fixes HDMI hotplug/output detection.
>
> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>
> Signed-off-by: Florian Klink <flokli@flokli.de>
Assuming Stefan is OK wit the change, I will apply this along with a:
Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO
board")
> ---
> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
> index 72d26d130efa..85f54fa595aa 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
> @@ -77,7 +77,7 @@ &gpio {
> };
>
> &hdmi {
> - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
> + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
> power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
> status = "okay";
> };
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
2024-07-15 23:19 ` Florian Fainelli
@ 2024-07-15 23:20 ` Florian Fainelli
2024-07-16 5:30 ` Stefan Wahren
1 sibling, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2024-07-15 23:20 UTC (permalink / raw)
To: Florian Fainelli, Florian Klink, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Ray Jui, Scott Branden,
Broadcom internal kernel review list, devicetree,
linux-rpi-kernel, linux-arm-kernel, linux-kernel, Stefan Wahren
On 7/15/24 16:19, Florian Fainelli wrote:
> +Stefan,
With the correct email this time...
>
> On 7/15/24 16:03, Florian Klink wrote:
>> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>>
>> This fixes HDMI hotplug/output detection.
>>
>> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>>
>> Signed-off-by: Florian Klink <flokli@flokli.de>
>
> Assuming Stefan is OK wit the change, I will apply this along with a:
>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO
> board")
>
>> ---
>> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> index 72d26d130efa..85f54fa595aa 100644
>> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> @@ -77,7 +77,7 @@ &gpio {
>> };
>> &hdmi {
>> - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
>> + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
>> power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
>> status = "okay";
>> };
>
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
2024-07-15 23:19 ` Florian Fainelli
2024-07-15 23:20 ` Florian Fainelli
@ 2024-07-16 5:30 ` Stefan Wahren
2024-07-16 17:08 ` Florian Klink
1 sibling, 1 reply; 7+ messages in thread
From: Stefan Wahren @ 2024-07-16 5:30 UTC (permalink / raw)
To: Florian Fainelli, Florian Klink, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, devicetree,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
Hi,
Am 16.07.24 um 01:19 schrieb Florian Fainelli:
> +Stefan,
>
> On 7/15/24 16:03, Florian Klink wrote:
>> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>>
>> This fixes HDMI hotplug/output detection.
>>
>> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>>
>> Signed-off-by: Florian Klink <flokli@flokli.de>
>
> Assuming Stefan is OK wit the change, I will apply this along with a:
>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and
> IO board")
thanks for fixing and i'm fine with this change. The GPIO line names are
already correct.
Maybe the subject should be more specific:
ARM: dts: bcm2837-rpi-cm3-io3: Fix HDMI hpd-gpio pin
Except of this:
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Regards
>
>> ---
>> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> index 72d26d130efa..85f54fa595aa 100644
>> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>> @@ -77,7 +77,7 @@ &gpio {
>> };
>> &hdmi {
>> - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
>> + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
>> power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
>> status = "okay";
>> };
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
2024-07-16 5:30 ` Stefan Wahren
@ 2024-07-16 17:08 ` Florian Klink
2024-07-16 17:22 ` Florian Fainelli
0 siblings, 1 reply; 7+ messages in thread
From: Florian Klink @ 2024-07-16 17:08 UTC (permalink / raw)
To: Stefan Wahren
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden,
Broadcom internal kernel review list, devicetree,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
Hey,
fine with the subject change too :-)
@Florian: Let me know if you want me to roll all in a v2 or are happy to
apply that subject change too.
Cheers,
flokli
On Tue, Jul 16, 2024 at 07:30:32AM GMT, Stefan Wahren wrote:
>Hi,
>
>Am 16.07.24 um 01:19 schrieb Florian Fainelli:
>>+Stefan,
>>
>>On 7/15/24 16:03, Florian Klink wrote:
>>>HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>>>
>>>This fixes HDMI hotplug/output detection.
>>>
>>>See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>>>
>>>Signed-off-by: Florian Klink <flokli@flokli.de>
>>
>>Assuming Stefan is OK wit the change, I will apply this along with a:
>>
>>Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and
>>IO board")
>thanks for fixing and i'm fine with this change. The GPIO line names are
>already correct.
>
>Maybe the subject should be more specific:
>
>ARM: dts: bcm2837-rpi-cm3-io3: Fix HDMI hpd-gpio pin
>
>Except of this:
>
>Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
>
>Regards
>>
>>>---
>>> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>index 72d26d130efa..85f54fa595aa 100644
>>>--- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>+++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts
>>>@@ -77,7 +77,7 @@ &gpio {
>>> };
>>> &hdmi {
>>>- hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
>>>+ hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>;
>>> power-domains = <&power RPI_POWER_DOMAIN_HDMI>;
>>> status = "okay";
>>> };
>>
>
--
Florian Klink
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
2024-07-16 17:08 ` Florian Klink
@ 2024-07-16 17:22 ` Florian Fainelli
0 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2024-07-16 17:22 UTC (permalink / raw)
To: Florian Klink, Stefan Wahren
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Ray Jui, Scott Branden, Broadcom internal kernel review list,
devicetree, linux-rpi-kernel, linux-arm-kernel, linux-kernel
On 7/16/24 10:08, Florian Klink wrote:
> Hey,
>
> fine with the subject change too :-)
>
> @Florian: Let me know if you want me to roll all in a v2 or are happy to
> apply that subject change too.
Will fix it up while applying, no need for a v2, thanks!
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin
2024-07-15 23:03 [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin Florian Klink
2024-07-15 23:19 ` Florian Fainelli
@ 2024-07-16 17:47 ` Florian Fainelli
1 sibling, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2024-07-16 17:47 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Florian Klink, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Ray Jui,
Scott Branden, devicetree, linux-rpi-kernel, linux-arm-kernel,
linux-kernel
Cc: Florian Fainelli
From: Florian Fainelli <f.fainelli@gmail.com>
On Tue, 16 Jul 2024 02:03:11 +0300, Florian Klink <flokli@flokli.de> wrote:
> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1.
>
> This fixes HDMI hotplug/output detection.
>
> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf
>
> Signed-off-by: Florian Klink <flokli@flokli.de>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-16 17:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 23:03 [PATCH] ARM: dts: bcm283x: Fix hdmi hpd-gpio pin Florian Klink
2024-07-15 23:19 ` Florian Fainelli
2024-07-15 23:20 ` Florian Fainelli
2024-07-16 5:30 ` Stefan Wahren
2024-07-16 17:08 ` Florian Klink
2024-07-16 17:22 ` Florian Fainelli
2024-07-16 17:47 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox