From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Pavel Skripkin <paskripkin@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
Rebecca Mckeever <remckee0@gmail.com>,
Martin Kaiser <martin@kaiser.cx>,
Vihas Makwana <makvihas@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: r8188eu: Inserted empty line after declarations
Date: Fri, 22 Jul 2022 20:51:05 +0200 [thread overview]
Message-ID: <fb10f8bf-d2d8-a2e2-435a-62bb9ce02973@gmail.com> (raw)
In-Reply-To: <20220722161744.14914-1-abhijeet.srivastava2308@gmail.com>
On 7/22/22 18:16, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
Empty line missing.
> Signed-off-by: Abhijeet Srivastava<abhijeet.srivastava2308@gmail.com>
> ---
> v2:
> - Fix my name on the patch
> v3:
> - Fix commit message
> v4:
> - Fix body of explanation
I would like to give you a reviewed by but now the empty line above the
Signed-off is missing. Please have a look at the canonical patch format.
Regards,
Philipp
prev parent reply other threads:[~2022-07-22 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 16:16 [PATCH v4] staging: r8188eu: Inserted empty line after declarations Abhijeet Srivastava
2022-07-22 18:51 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb10f8bf-d2d8-a2e2-435a-62bb9ce02973@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=abhijeet.srivastava2308@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=makvihas@gmail.com \
--cc=martin@kaiser.cx \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=remckee0@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox