* [PATCH v4] staging: r8188eu: Inserted empty line after declarations
@ 2022-07-22 16:16 Abhijeet Srivastava
2022-07-22 18:51 ` Philipp Hortmann
0 siblings, 1 reply; 2+ messages in thread
From: Abhijeet Srivastava @ 2022-07-22 16:16 UTC (permalink / raw)
Cc: abhijeet.srivastava2308, Larry Finger, Phillip Potter,
Pavel Skripkin, Greg Kroah-Hartman, Michael Straube,
Rebecca Mckeever, Martin Kaiser, Vihas Makwana, linux-staging,
linux-kernel
Warning found by checkpatch.pl script.
Signed-off-by: Abhijeet Srivastava <abhijeet.srivastava2308@gmail.com>
---
v2:
- Fix my name on the patch
v3:
- Fix commit message
v4:
- Fix body of explanation
drivers/staging/r8188eu/core/rtw_cmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index 5b6a891b5d67..6fbf6e4234cf 100644
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -25,6 +25,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv)
while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) {
void *c2h = rtw_cbuf_pop(pevtpriv->c2h_queue);
+
if (c2h && c2h != (void *)pevtpriv)
kfree(c2h);
}
@@ -323,6 +324,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
/* prepare ssid list */
if (ssid) {
int i;
+
for (i = 0; i < ssid_num && i < RTW_SSID_SCAN_AMOUNT; i++) {
if (ssid[i].SsidLength) {
memcpy(&psurveyPara->ssid[i], &ssid[i], sizeof(struct ndis_802_11_ssid));
@@ -334,6 +336,7 @@ u8 rtw_sitesurvey_cmd(struct adapter *padapter, struct ndis_802_11_ssid *ssid,
/* prepare channel list */
if (ch) {
int i;
+
for (i = 0; i < ch_num && i < RTW_CHANNEL_SCAN_AMOUNT; i++) {
if (ch[i].hw_value && !(ch[i].flags & RTW_IEEE80211_CHAN_DISABLED)) {
memcpy(&psurveyPara->ch[i], &ch[i], sizeof(struct rtw_ieee80211_channel));
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v4] staging: r8188eu: Inserted empty line after declarations
2022-07-22 16:16 [PATCH v4] staging: r8188eu: Inserted empty line after declarations Abhijeet Srivastava
@ 2022-07-22 18:51 ` Philipp Hortmann
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Hortmann @ 2022-07-22 18:51 UTC (permalink / raw)
To: Abhijeet Srivastava
Cc: Larry Finger, Phillip Potter, Pavel Skripkin, Greg Kroah-Hartman,
Michael Straube, Rebecca Mckeever, Martin Kaiser, Vihas Makwana,
linux-staging, linux-kernel
On 7/22/22 18:16, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
Empty line missing.
> Signed-off-by: Abhijeet Srivastava<abhijeet.srivastava2308@gmail.com>
> ---
> v2:
> - Fix my name on the patch
> v3:
> - Fix commit message
> v4:
> - Fix body of explanation
I would like to give you a reviewed by but now the empty line above the
Signed-off is missing. Please have a look at the canonical patch format.
Regards,
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-22 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-22 16:16 [PATCH v4] staging: r8188eu: Inserted empty line after declarations Abhijeet Srivastava
2022-07-22 18:51 ` Philipp Hortmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox