* [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq
@ 2006-10-14 9:01 Yinghai Lu
2006-10-14 10:06 ` Eric W. Biederman
2006-10-17 17:03 ` Eric W. Biederman
0 siblings, 2 replies; 4+ messages in thread
From: Yinghai Lu @ 2006-10-14 9:01 UTC (permalink / raw)
To: Eric W. Biederman, Andi Kleen; +Cc: linux kernel mailing list, yhlu.kernel
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
using irq_domain[irq] to get cpu_mask for send_IPI_mask
Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index 44b55f8..6a07bce 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
static int ioapic_retrigger_irq(unsigned int irq)
{
cpumask_t mask;
- unsigned vector;
+ int vector;
vector = irq_vector[irq];
- cpus_clear(mask);
- cpu_set(vector >> 8, mask);
+ mask = irq_domain[irq];
- send_IPI_mask(mask, vector & 0xff);
+ send_IPI_mask(mask, vector);
return 1;
}
[-- Attachment #2: io_apic_irq_trigger.diff --]
[-- Type: text/x-patch, Size: 537 bytes --]
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index 44b55f8..6a07bce 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
static int ioapic_retrigger_irq(unsigned int irq)
{
cpumask_t mask;
- unsigned vector;
+ int vector;
vector = irq_vector[irq];
- cpus_clear(mask);
- cpu_set(vector >> 8, mask);
+ mask = irq_domain[irq];
- send_IPI_mask(mask, vector & 0xff);
+ send_IPI_mask(mask, vector);
return 1;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq
2006-10-14 9:01 [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq Yinghai Lu
@ 2006-10-14 10:06 ` Eric W. Biederman
2006-10-17 17:03 ` Eric W. Biederman
1 sibling, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2006-10-14 10:06 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Andi Kleen, linux kernel mailing list, yhlu.kernel
"Yinghai Lu" <yinghai.lu@amd.com> writes:
> using irq_domain[irq] to get cpu_mask for send_IPI_mask
Yep. I missed that one in my last refactoring :(
Acked-by: Eric W. Biederman <ebiederm@xmission.com>
Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq
2006-10-14 9:01 [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq Yinghai Lu
2006-10-14 10:06 ` Eric W. Biederman
@ 2006-10-17 17:03 ` Eric W. Biederman
1 sibling, 0 replies; 4+ messages in thread
From: Eric W. Biederman @ 2006-10-17 17:03 UTC (permalink / raw)
To: Yinghai Lu; +Cc: Andi Kleen, linux kernel mailing list, yhlu.kernel
"Yinghai Lu" <yinghai.lu@amd.com> writes:
> using irq_domain[irq] to get cpu_mask for send_IPI_mask
>
> Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
YH I have to grumble at you, your patch suffers from white space damage
and does not apply.
In addition while looking this version is actually broken because
for retrigger irq we only ever want to send the irq once and your
version has the potential to be broadcast to several cpus. Not
what we want.
I will send a fixed version in a minute.
Eric
>
> diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
> index 44b55f8..6a07bce 100644
> --- a/arch/x86_64/kernel/io_apic.c
> +++ b/arch/x86_64/kernel/io_apic.c
> @@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
> static int ioapic_retrigger_irq(unsigned int irq)
> {
> cpumask_t mask;
> - unsigned vector;
> + int vector;
>
> vector = irq_vector[irq];
> - cpus_clear(mask);
> - cpu_set(vector >> 8, mask);
> + mask = irq_domain[irq];
>
> - send_IPI_mask(mask, vector & 0xff);
> + send_IPI_mask(mask, vector);
>
> return 1;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq
@ 2006-10-17 17:28 Lu, Yinghai
0 siblings, 0 replies; 4+ messages in thread
From: Lu, Yinghai @ 2006-10-17 17:28 UTC (permalink / raw)
To: ebiederm; +Cc: Andi Kleen, linux kernel mailing list, yhlu.kernel
Good, So need to find out the correct mask for irq ever used.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-10-17 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-14 9:01 [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq Yinghai Lu
2006-10-14 10:06 ` Eric W. Biederman
2006-10-17 17:03 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2006-10-17 17:28 Lu, Yinghai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox