The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* Re: [PATCH 4/21] MSI: Simplify BUG() handling in msi_remove_pci_irq_vectors() part 2
       [not found] <20070322105334.B5A46DDF59@ozlabs.org>
@ 2007-03-28  3:26 ` Eric W. Biederman
  0 siblings, 0 replies; only message in thread
From: Eric W. Biederman @ 2007-03-28  3:26 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: linux-pci, Greg Kroah-Hartman, David S. Miller,
	Benjamin Herrenschmidt, linux-kernel, Andrew Morton,
	daniel.e.wolstenholme

Michael Ellerman <michael@ellerman.id.au> writes:

> Although it might be nice to do a printk before BUG'ing, it's really not
> necessary, and it complicates the code.
>
> The behaviour has changed slightly, in that before we set a flag if the irq
> had an action, and continued freeing the other irqs. But as I see it that's
> all irrelevant because we end up BUG'ing anyway.

Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-28  3:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20070322105334.B5A46DDF59@ozlabs.org>
2007-03-28  3:26 ` [PATCH 4/21] MSI: Simplify BUG() handling in msi_remove_pci_irq_vectors() part 2 Eric W. Biederman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox