* [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9
@ 2022-03-17 22:11 Kai-Heng Feng
2022-03-18 8:19 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Kai-Heng Feng @ 2022-03-17 22:11 UTC (permalink / raw)
To: tiwai
Cc: Kai-Heng Feng, Jaroslav Kysela, Jeremy Szu, Werner Sembach,
Hui Wang, Lucas Tanure, Cameron Berkenpas, Kailang Yang,
Sami Loone, Hans de Goede, Stefan Binding, alsa-devel,
linux-kernel
Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
breaks mute and micmute LEDs because it changed the LED quirk from
ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
here.
Also reorder the chain of quirks to ensure LED quirk is the last one
being applied.
Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
sound/pci/hda/patch_realtek.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4650ef9110d62..1d14be4ee31d8 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8773,9 +8773,9 @@ static const struct hda_fixup alc269_fixups[] = {
},
[ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED] = {
.type = HDA_FIXUP_FUNC,
- .v.func = alc245_fixup_hp_gpio_led,
+ .v.func = cs35l41_fixup_spi_four,
.chained = true,
- .chain_id = ALC245_FIXUP_CS35L41_SPI_4,
+ .chain_id = ALC285_FIXUP_HP_GPIO_LED,
},
[ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED] = {
.type = HDA_FIXUP_VERBS,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9
2022-03-17 22:11 [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9 Kai-Heng Feng
@ 2022-03-18 8:19 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2022-03-18 8:19 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: tiwai, Jaroslav Kysela, Jeremy Szu, Werner Sembach, Hui Wang,
Lucas Tanure, Cameron Berkenpas, Kailang Yang, Sami Loone,
Hans de Goede, Stefan Binding, alsa-devel, linux-kernel
On Thu, 17 Mar 2022 23:11:33 +0100,
Kai-Heng Feng wrote:
>
> Commit 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> breaks mute and micmute LEDs because it changed the LED quirk from
> ALC285_FIXUP_HP_GPIO_LED to ALC245_FIXUP_HP_GPIO_LED, so change it back
> here.
>
> Also reorder the chain of quirks to ensure LED quirk is the last one
> being applied.
>
> Fixes: 07bcab93946c ("ALSA: hda/realtek: Add support for HP Laptops")
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-18 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-17 22:11 [PATCH] ALSA: hda/realtek: Fix LED on Zbook Studio G9 Kai-Heng Feng
2022-03-18 8:19 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox