* [PATCH] Fixed typo on line 733.
@ 2018-06-27 18:54 Guy Chronister
2018-06-28 5:39 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Guy Chronister @ 2018-06-27 18:54 UTC (permalink / raw)
To: guychronister
Cc: Guy Chronister, Clemens Ladisch, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Signed-off-by: Guy Chronister <guylovesbritt@gmail.com>
---
sound/pci/oxygen/oxygen_mixer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
index 81af21a..ba87213 100644
--- a/sound/pci/oxygen/oxygen_mixer.c
+++ b/sound/pci/oxygen/oxygen_mixer.c
@@ -730,7 +730,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl,
oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN);
newreg = oldreg & ~0x0707;
newreg = newreg | (value->value.integer.value[0] & 7);
- newreg = newreg | ((value->value.integer.value[0] & 7) << 8);
+ newreg = newreg | ((value->value.integer.value[1] & 7) << 8);
change = newreg != oldreg;
if (change)
oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fixed typo on line 733.
2018-06-27 18:54 [PATCH] Fixed typo on line 733 Guy Chronister
@ 2018-06-28 5:39 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2018-06-28 5:39 UTC (permalink / raw)
To: Guy Chronister
Cc: guychronister, alsa-devel, Clemens Ladisch, Jaroslav Kysela,
linux-kernel
On Wed, 27 Jun 2018 20:54:34 +0200,
Guy Chronister wrote:
>
> Signed-off-by: Guy Chronister <guylovesbritt@gmail.com>
The code change itself is good, but the subject is wrong, and there is
no changelog texts. Please describe what it really fixes. It's not
about typo fix, but it fixes a real bug, and this has to be written in
the subject and explained in more details in the changelog.
thanks,
Takashi
> ---
> sound/pci/oxygen/oxygen_mixer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
> index 81af21a..ba87213 100644
> --- a/sound/pci/oxygen/oxygen_mixer.c
> +++ b/sound/pci/oxygen/oxygen_mixer.c
> @@ -730,7 +730,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl,
> oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN);
> newreg = oldreg & ~0x0707;
> newreg = newreg | (value->value.integer.value[0] & 7);
> - newreg = newreg | ((value->value.integer.value[0] & 7) << 8);
> + newreg = newreg | ((value->value.integer.value[1] & 7) << 8);
> change = newreg != oldreg;
> if (change)
> oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg);
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-28 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-27 18:54 [PATCH] Fixed typo on line 733 Guy Chronister
2018-06-28 5:39 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox