From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: Mike Danese <mikedanese@google.com>
Cc: "Dutt\, Sudeep" <sudeep.dutt@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Chandramouli\,
Dasaratharaman" <dasaratharaman.chandramouli@intel.com>,
Mahesh Khanwalkar <maheshkhanwalkar@gmail.com>,
"open list\:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mpssd: fix buffer overflow warning
Date: Fri, 20 May 2016 01:07:38 -0400 [thread overview]
Message-ID: <tnm1tvb29z59h.fsf@phwtpriv05.ph.intel.com> (raw)
In-Reply-To: <1463720092-18470-1-git-send-email-mikedanese@google.com> (Mike Danese's message of "Thu, 19 May 2016 22:54:51 -0600")
On Fri, May 20 2016 at 12:54:51 AM, Mike Danese <mikedanese@google.com> wrote:
> The compilation emits a warning in function ‘snprintf’,
> inlined from ‘set_cmdline’ at
> ../Documentation/mic/mpssd/mpssd.c:1541:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
> warning: call to __builtin___snprintf_chk will always overflow
> destination buffer
>
> This was introduced in commit f4a66c204482 ("misc: mic: Update MIC host
> daemon with COSM changes") and is fixed by reverting the changes to the
> size argument of these snprintf statements.
Thanks for the patch, the fix is fine.
next prev parent reply other threads:[~2016-05-20 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 4:54 [PATCH] mpssd: fix buffer overflow warning Mike Danese
2016-05-20 5:07 ` Ashutosh Dixit [this message]
2016-06-03 19:32 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tnm1tvb29z59h.fsf@phwtpriv05.ph.intel.com \
--to=ashutosh.dixit@intel.com \
--cc=corbet@lwn.net \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maheshkhanwalkar@gmail.com \
--cc=mikedanese@google.com \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox