* [PATCH] mpssd: fix buffer overflow warning
@ 2016-05-20 4:54 Mike Danese
2016-05-20 5:07 ` Ashutosh Dixit
2016-06-03 19:32 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Mike Danese @ 2016-05-20 4:54 UTC (permalink / raw)
Cc: Mike Danese, Ashutosh Dixit, Sudeep Dutt, Jonathan Corbet,
Greg Kroah-Hartman, Dasaratharaman Chandramouli,
Mahesh Khanwalkar, open list:DOCUMENTATION, open list
The compilation emits a warning in function ‘snprintf’,
inlined from ‘set_cmdline’ at
../Documentation/mic/mpssd/mpssd.c:1541:9:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
warning: call to __builtin___snprintf_chk will always overflow
destination buffer
This was introduced in commit f4a66c204482 ("misc: mic: Update MIC host
daemon with COSM changes") and is fixed by reverting the changes to the
size argument of these snprintf statements.
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
Signed-off-by: Mike Danese <mikedanese@google.com>
---
Documentation/mic/mpssd/mpssd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/mic/mpssd/mpssd.c b/Documentation/mic/mpssd/mpssd.c
index 30fb842..49db1de 100644
--- a/Documentation/mic/mpssd/mpssd.c
+++ b/Documentation/mic/mpssd/mpssd.c
@@ -1538,9 +1538,9 @@ set_cmdline(struct mic_info *mic)
len = snprintf(buffer, PATH_MAX,
"clocksource=tsc highres=off nohz=off ");
- len += snprintf(buffer + len, PATH_MAX,
+ len += snprintf(buffer + len, PATH_MAX - len,
"cpufreq_on;corec6_off;pc3_off;pc6_off ");
- len += snprintf(buffer + len, PATH_MAX,
+ len += snprintf(buffer + len, PATH_MAX - len,
"ifcfg=static;address,172.31.%d.1;netmask,255.255.255.0",
mic->id + 1);
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mpssd: fix buffer overflow warning
2016-05-20 4:54 [PATCH] mpssd: fix buffer overflow warning Mike Danese
@ 2016-05-20 5:07 ` Ashutosh Dixit
2016-06-03 19:32 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Ashutosh Dixit @ 2016-05-20 5:07 UTC (permalink / raw)
To: Mike Danese
Cc: Dutt, Sudeep, Jonathan Corbet, Greg Kroah-Hartman,
Chandramouli, Dasaratharaman, Mahesh Khanwalkar,
open list:DOCUMENTATION, open list
On Fri, May 20 2016 at 12:54:51 AM, Mike Danese <mikedanese@google.com> wrote:
> The compilation emits a warning in function ‘snprintf’,
> inlined from ‘set_cmdline’ at
> ../Documentation/mic/mpssd/mpssd.c:1541:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
> warning: call to __builtin___snprintf_chk will always overflow
> destination buffer
>
> This was introduced in commit f4a66c204482 ("misc: mic: Update MIC host
> daemon with COSM changes") and is fixed by reverting the changes to the
> size argument of these snprintf statements.
Thanks for the patch, the fix is fine.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mpssd: fix buffer overflow warning
2016-05-20 4:54 [PATCH] mpssd: fix buffer overflow warning Mike Danese
2016-05-20 5:07 ` Ashutosh Dixit
@ 2016-06-03 19:32 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2016-06-03 19:32 UTC (permalink / raw)
To: Mike Danese
Cc: Ashutosh Dixit, Sudeep Dutt, Greg Kroah-Hartman,
Dasaratharaman Chandramouli, Mahesh Khanwalkar,
open list:DOCUMENTATION, open list
On Thu, 19 May 2016 21:54:51 -0700
Mike Danese <mikedanese@google.com> wrote:
> The compilation emits a warning in function ‘snprintf’,
> inlined from ‘set_cmdline’ at
> ../Documentation/mic/mpssd/mpssd.c:1541:9:
> /usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10:
> warning: call to __builtin___snprintf_chk will always overflow
> destination buffer
Applied to the docs tree, thanks. I do wonder if Documentation/ is the
best place for this tool, though...
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-03 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 4:54 [PATCH] mpssd: fix buffer overflow warning Mike Danese
2016-05-20 5:07 ` Ashutosh Dixit
2016-06-03 19:32 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox