* [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled
@ 2019-03-07 21:49 Finn Thain
2019-03-19 18:19 ` Martin K. Petersen
2019-04-08 23:44 ` Gustavo A. R. Silva
0 siblings, 2 replies; 5+ messages in thread
From: Finn Thain @ 2019-03-07 21:49 UTC (permalink / raw)
To: James E.J. Bottomley, Martin K. Petersen
Cc: Gustavo A. R. Silva, Michael Schmitz, linux-scsi, linux-kernel
Adjust comments accordingly.
Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/scsi/NCR5380.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 7fed9bb72784..fe0535affc14 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
if (!hostdata->connected)
return;
- /* Fall through to reject message */
-
+ /* Reject message */
+ /* Fall through */
+ default:
/*
* If we get something weird that we aren't expecting,
- * reject it.
+ * log it.
*/
- default:
if (tmp == EXTENDED_MESSAGE)
scmd_printk(KERN_INFO, cmd,
"rejecting unknown extended message code %02x, length %d\n",
--
2.19.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled
2019-03-07 21:49 [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled Finn Thain
@ 2019-03-19 18:19 ` Martin K. Petersen
2019-04-08 23:44 ` Gustavo A. R. Silva
1 sibling, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2019-03-19 18:19 UTC (permalink / raw)
To: Finn Thain
Cc: James E.J. Bottomley, Martin K. Petersen, Gustavo A. R. Silva,
Michael Schmitz, linux-scsi, linux-kernel
Finn,
> Adjust comments accordingly.
Applied to 5.2/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled
2019-03-07 21:49 [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled Finn Thain
2019-03-19 18:19 ` Martin K. Petersen
@ 2019-04-08 23:44 ` Gustavo A. R. Silva
2019-04-09 0:22 ` Finn Thain
1 sibling, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-08 23:44 UTC (permalink / raw)
To: Finn Thain, James E.J. Bottomley, Martin K. Petersen
Cc: Michael Schmitz, linux-scsi, linux-kernel
Hi all,
Friendly ping:
Who can take this?
Thanks
On 3/7/19 3:49 PM, Finn Thain wrote:
> Adjust comments accordingly.
>
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Michael Schmitz <schmitzmic@gmail.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> ---
> drivers/scsi/NCR5380.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 7fed9bb72784..fe0535affc14 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
> if (!hostdata->connected)
> return;
>
> - /* Fall through to reject message */
> -
> + /* Reject message */
> + /* Fall through */
> + default:
> /*
> * If we get something weird that we aren't expecting,
> - * reject it.
> + * log it.
> */
> - default:
> if (tmp == EXTENDED_MESSAGE)
> scmd_printk(KERN_INFO, cmd,
> "rejecting unknown extended message code %02x, length %d\n",
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled
2019-04-08 23:44 ` Gustavo A. R. Silva
@ 2019-04-09 0:22 ` Finn Thain
2019-04-09 22:28 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Finn Thain @ 2019-04-09 0:22 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: James E.J. Bottomley, Martin K. Petersen, Michael Schmitz,
linux-scsi, linux-kernel
On Mon, 8 Apr 2019, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
>
> Thanks
>
It has been queued up by Martin and James on git.kernel.org. Apparently it
is to be pushed in the v5.2 merge window.
--
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled
2019-04-09 0:22 ` Finn Thain
@ 2019-04-09 22:28 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-09 22:28 UTC (permalink / raw)
To: Finn Thain
Cc: James E.J. Bottomley, Martin K. Petersen, Michael Schmitz,
linux-scsi, linux-kernel
On 4/8/19 7:22 PM, Finn Thain wrote:
>
> It has been queued up by Martin and James on git.kernel.org. Apparently it
> is to be pushed in the v5.2 merge window.
>
Awesome.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-09 22:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-07 21:49 [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled Finn Thain
2019-03-19 18:19 ` Martin K. Petersen
2019-04-08 23:44 ` Gustavo A. R. Silva
2019-04-09 0:22 ` Finn Thain
2019-04-09 22:28 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox