[PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

[PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

[Finn Thain]

Adjust comments accordingly.

Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
 drivers/scsi/NCR5380.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 7fed9bb72784..fe0535affc14 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
 					if (!hostdata->connected)
 						return;
 
-					/* Fall through to reject message */
-
+					/* Reject message */
+					/* Fall through */
+				default:
 					/*
 					 * If we get something weird that we aren't expecting,
-					 * reject it.
+					 * log it.
 					 */
-				default:
 					if (tmp == EXTENDED_MESSAGE)
 						scmd_printk(KERN_INFO, cmd,
 						            "rejecting unknown extended message code %02x, length %d\n",
-- 
2.19.2

Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

[Martin K. Petersen]

Finn,

> Adjust comments accordingly.

Applied to 5.2/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

[Gustavo A. R. Silva]

Hi all,

Friendly ping:

Who can take this?

Thanks

On 3/7/19 3:49 PM, Finn Thain wrote:
> Adjust comments accordingly.
> 
> Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Cc: Michael Schmitz <schmitzmic@gmail.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> ---
>  drivers/scsi/NCR5380.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index 7fed9bb72784..fe0535affc14 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
>  					if (!hostdata->connected)
>  						return;
>  
> -					/* Fall through to reject message */
> -
> +					/* Reject message */
> +					/* Fall through */
> +				default:
>  					/*
>  					 * If we get something weird that we aren't expecting,
> -					 * reject it.
> +					 * log it.
>  					 */
> -				default:
>  					if (tmp == EXTENDED_MESSAGE)
>  						scmd_printk(KERN_INFO, cmd,
>  						            "rejecting unknown extended message code %02x, length %d\n",
> 

Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

[Finn Thain]

On Mon, 8 Apr 2019, Gustavo A. R. Silva wrote:

> Hi all,
> 
> Friendly ping:
> 
> Who can take this?
> 
> Thanks
> 

It has been queued up by Martin and James on git.kernel.org. Apparently it 
is to be pushed in the v5.2 merge window.

-- 

Re: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled

[Gustavo A. R. Silva]

On 4/8/19 7:22 PM, Finn Thain wrote:
> 
> It has been queued up by Martin and James on git.kernel.org. Apparently it 
> is to be pushed in the v5.2 merge window.
> 

Awesome.

Thanks
--
Gustavo