* Re: [PATCH v2 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc [not found] <20220621012811.2683313-5-kpsingh@kernel.org> @ 2022-06-21 3:20 ` kernel test robot 2022-06-21 7:18 ` KP Singh 0 siblings, 1 reply; 4+ messages in thread From: kernel test robot @ 2022-06-21 3:20 UTC (permalink / raw) To: KP Singh, bpf Cc: llvm, kbuild-all, KP Singh, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Benjamin Tissoires, Yosry Ahmed Hi KP, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/KP-Singh/Add-bpf_getxattr/20220621-093013 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: x86_64-randconfig-a015-20220620 (https://download.01.org/0day-ci/archive/20220621/202206211035.p3LxbVfK-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/dd49d2ffb18adceafa98bd517008f59aa9bc910b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review KP-Singh/Add-bpf_getxattr/20220621-093013 git checkout dd49d2ffb18adceafa98bd517008f59aa9bc910b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/trace/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> kernel/trace/bpf_trace.c:1185:25: warning: no previous prototype for function 'bpf_getxattr' [-Wmissing-prototypes] noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, ^ kernel/trace/bpf_trace.c:1185:17: note: declare 'static' if the function is not intended to be used outside of this translation unit noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, ^ static 1 warning generated. vim +/bpf_getxattr +1185 kernel/trace/bpf_trace.c 1184 > 1185 noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, 1186 const char *name, void *value, int size) 1187 { 1188 return __vfs_getxattr(dentry, inode, name, value, size); 1189 } 1190 -- 0-DAY CI Kernel Test Service https://01.org/lkp ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc 2022-06-21 3:20 ` [PATCH v2 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc kernel test robot @ 2022-06-21 7:18 ` KP Singh 2022-06-21 12:41 ` Kumar Kartikeya Dwivedi 0 siblings, 1 reply; 4+ messages in thread From: KP Singh @ 2022-06-21 7:18 UTC (permalink / raw) To: kernel test robot Cc: bpf, llvm, kbuild-all, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Benjamin Tissoires, Yosry Ahmed On Tue, Jun 21, 2022 at 5:20 AM kernel test robot <lkp@intel.com> wrote: > > Hi KP, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/KP-Singh/Add-bpf_getxattr/20220621-093013 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: x86_64-randconfig-a015-20220620 (https://download.01.org/0day-ci/archive/20220621/202206211035.p3LxbVfK-lkp@intel.com/config) > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/dd49d2ffb18adceafa98bd517008f59aa9bc910b > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review KP-Singh/Add-bpf_getxattr/20220621-093013 > git checkout dd49d2ffb18adceafa98bd517008f59aa9bc910b > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/trace/ > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot <lkp@intel.com> > > All warnings (new ones prefixed by >>): > > >> kernel/trace/bpf_trace.c:1185:25: warning: no previous prototype for function 'bpf_getxattr' [-Wmissing-prototypes] > noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > ^ > kernel/trace/bpf_trace.c:1185:17: note: declare 'static' if the function is not intended to be used outside of this translation unit > noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > ^ > static > 1 warning generated. > So it looks like this needs a function prototype. Let's do an initial round of reviews on this series and I can respin with something like: diff --git a/kernel/trace/bpf_trace.h b/kernel/trace/bpf_trace.h index 9acbc11ac7bb..3f62e5d35037 100644 --- a/kernel/trace/bpf_trace.h +++ b/kernel/trace/bpf_trace.h @@ -25,6 +25,11 @@ TRACE_EVENT(bpf_trace_printk, TP_printk("%s", __get_str(bpf_string)) ); +/* Prototypes for kernel functions exposed to tracing and LSM + * programs + */ +ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, + const char *name, void *value, int size); #endif /* _TRACE_BPF_TRACE_H */ (or anything else folks suggest) - KP > > vim +/bpf_getxattr +1185 kernel/trace/bpf_trace.c > > 1184 > > 1185 noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > 1186 const char *name, void *value, int size) > 1187 { > 1188 return __vfs_getxattr(dentry, inode, name, value, size); > 1189 } > 1190 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc 2022-06-21 7:18 ` KP Singh @ 2022-06-21 12:41 ` Kumar Kartikeya Dwivedi 2022-06-21 16:06 ` KP Singh 0 siblings, 1 reply; 4+ messages in thread From: Kumar Kartikeya Dwivedi @ 2022-06-21 12:41 UTC (permalink / raw) To: KP Singh Cc: kernel test robot, bpf, llvm, kbuild-all, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Benjamin Tissoires, Yosry Ahmed On Tue, Jun 21, 2022 at 12:48:08PM IST, KP Singh wrote: > On Tue, Jun 21, 2022 at 5:20 AM kernel test robot <lkp@intel.com> wrote: > > > > Hi KP, > > > > I love your patch! Perhaps something to improve: > > > > [auto build test WARNING on bpf-next/master] > > > > url: https://github.com/intel-lab-lkp/linux/commits/KP-Singh/Add-bpf_getxattr/20220621-093013 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > > config: x86_64-randconfig-a015-20220620 (https://download.01.org/0day-ci/archive/20220621/202206211035.p3LxbVfK-lkp@intel.com/config) > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project af6d2a0b6825e71965f3e2701a63c239fa0ad70f) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://github.com/intel-lab-lkp/linux/commit/dd49d2ffb18adceafa98bd517008f59aa9bc910b > > git remote add linux-review https://github.com/intel-lab-lkp/linux > > git fetch --no-tags linux-review KP-Singh/Add-bpf_getxattr/20220621-093013 > > git checkout dd49d2ffb18adceafa98bd517008f59aa9bc910b > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/trace/ > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot <lkp@intel.com> > > > > All warnings (new ones prefixed by >>): > > > > >> kernel/trace/bpf_trace.c:1185:25: warning: no previous prototype for function 'bpf_getxattr' [-Wmissing-prototypes] > > noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > > ^ > > kernel/trace/bpf_trace.c:1185:17: note: declare 'static' if the function is not intended to be used outside of this translation unit > > noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > > ^ > > static > > 1 warning generated. > > > > So it looks like this needs a function prototype. Let's do an initial round > of reviews on this series and I can respin with something like: > > diff --git a/kernel/trace/bpf_trace.h b/kernel/trace/bpf_trace.h > index 9acbc11ac7bb..3f62e5d35037 100644 > --- a/kernel/trace/bpf_trace.h > +++ b/kernel/trace/bpf_trace.h > @@ -25,6 +25,11 @@ TRACE_EVENT(bpf_trace_printk, > TP_printk("%s", __get_str(bpf_string)) > ); > > +/* Prototypes for kernel functions exposed to tracing and LSM > + * programs > + */ > +ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > + const char *name, void *value, int size); > #endif /* _TRACE_BPF_TRACE_H */ > > (or anything else folks suggest) > You can silence this warning using __diag_push, e.g. see kfunc definitions in net/netfilter/nf_conntrack_bpf.c. > - KP > > > > > vim +/bpf_getxattr +1185 kernel/trace/bpf_trace.c > > > > 1184 > > > 1185 noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > > 1186 const char *name, void *value, int size) > > 1187 { > > 1188 return __vfs_getxattr(dentry, inode, name, value, size); > > 1189 } > > 1190 > > > > -- > > 0-DAY CI Kernel Test Service > > https://01.org/lkp -- Kartikeya ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc 2022-06-21 12:41 ` Kumar Kartikeya Dwivedi @ 2022-06-21 16:06 ` KP Singh 0 siblings, 0 replies; 4+ messages in thread From: KP Singh @ 2022-06-21 16:06 UTC (permalink / raw) To: Kumar Kartikeya Dwivedi Cc: kernel test robot, bpf, llvm, kbuild-all, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Benjamin Tissoires, Yosry Ahmed On Tue, Jun 21, 2022 at 2:41 PM Kumar Kartikeya Dwivedi <memxor@gmail.com> wrote: > > On Tue, Jun 21, 2022 at 12:48:08PM IST, KP Singh wrote: > > On Tue, Jun 21, 2022 at 5:20 AM kernel test robot <lkp@intel.com> wrote: > > > > > > Hi KP, > > > > > > I love your patch! Perhaps something to improve: > > > > > > [auto build test WARNING on bpf-next/master] [...] > > > > You can silence this warning using __diag_push, e.g. see kfunc definitions in > net/netfilter/nf_conntrack_bpf.c. Thanks, done. > > > - KP > > > > > > > > vim +/bpf_getxattr +1185 kernel/trace/bpf_trace.c > > > > > > 1184 > > > > 1185 noinline __weak ssize_t bpf_getxattr(struct dentry *dentry, struct inode *inode, > > > 1186 const char *name, void *value, int size) > > > 1187 { > > > 1188 return __vfs_getxattr(dentry, inode, name, value, size); > > > 1189 } > > > 1190 > > > > > > -- > > > 0-DAY CI Kernel Test Service > > > https://01.org/lkp > > -- > Kartikeya ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-21 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220621012811.2683313-5-kpsingh@kernel.org>
2022-06-21 3:20 ` [PATCH v2 bpf-next 4/5] bpf: Add a bpf_getxattr kfunc kernel test robot
2022-06-21 7:18 ` KP Singh
2022-06-21 12:41 ` Kumar Kartikeya Dwivedi
2022-06-21 16:06 ` KP Singh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox