* Re: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code
[not found] <E1s6C4O-00Ck6O-9D@rmk-PC.armlinux.org.uk>
@ 2024-05-13 5:15 ` kernel test robot
2024-05-25 4:24 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-05-13 5:15 UTC (permalink / raw)
To: Russell King (Oracle); +Cc: llvm, oe-kbuild-all
Hi Russell,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-stmmac-remove-pcs_ctrl_ane-method-and-associated-code/20240513-003120
base: net-next/main
patch link: https://lore.kernel.org/r/E1s6C4O-00Ck6O-9D%40rmk-PC.armlinux.org.uk
patch subject: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240513/202405131223.7F8xA20v-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240513/202405131223.7F8xA20v-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405131223.7F8xA20v-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:628:3: error: implicit declaration of function 'stmmac_pcs_ctrl_ane' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0);
^
1 error generated.
vim +/stmmac_pcs_ctrl_ane +628 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
a7c30e62d4b895 Vinod Koul 2019-01-21 607
981d947bcd382c Sneh Shah 2023-12-12 608 /* On interface toggle MAC registers gets reset.
981d947bcd382c Sneh Shah 2023-12-12 609 * Configure MAC block for SGMII on ethernet phy link up
981d947bcd382c Sneh Shah 2023-12-12 610 */
463120c31c58bb Bartosz Golaszewski 2023-06-19 611 static int ethqos_configure_sgmii(struct qcom_ethqos *ethqos)
463120c31c58bb Bartosz Golaszewski 2023-06-19 612 {
a818bd12538c14 Sneh Shah 2024-02-20 613 struct net_device *dev = platform_get_drvdata(ethqos->pdev);
a818bd12538c14 Sneh Shah 2024-02-20 614 struct stmmac_priv *priv = netdev_priv(dev);
463120c31c58bb Bartosz Golaszewski 2023-06-19 615 int val;
463120c31c58bb Bartosz Golaszewski 2023-06-19 616
463120c31c58bb Bartosz Golaszewski 2023-06-19 617 val = readl(ethqos->mac_base + MAC_CTRL_REG);
463120c31c58bb Bartosz Golaszewski 2023-06-19 618
463120c31c58bb Bartosz Golaszewski 2023-06-19 619 switch (ethqos->speed) {
a818bd12538c14 Sneh Shah 2024-02-20 620 case SPEED_2500:
a818bd12538c14 Sneh Shah 2024-02-20 621 val &= ~ETHQOS_MAC_CTRL_PORT_SEL;
a818bd12538c14 Sneh Shah 2024-02-20 622 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
a818bd12538c14 Sneh Shah 2024-02-20 623 RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
a818bd12538c14 Sneh Shah 2024-02-20 624 RGMII_IO_MACRO_CONFIG2);
a818bd12538c14 Sneh Shah 2024-02-20 625 if (ethqos->serdes_speed != SPEED_2500)
a818bd12538c14 Sneh Shah 2024-02-20 626 phy_set_speed(ethqos->serdes_phy, SPEED_2500);
a818bd12538c14 Sneh Shah 2024-02-20 627 ethqos->serdes_speed = SPEED_2500;
a818bd12538c14 Sneh Shah 2024-02-20 @628 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0);
a818bd12538c14 Sneh Shah 2024-02-20 629 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 630 case SPEED_1000:
463120c31c58bb Bartosz Golaszewski 2023-06-19 631 val &= ~ETHQOS_MAC_CTRL_PORT_SEL;
463120c31c58bb Bartosz Golaszewski 2023-06-19 632 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
463120c31c58bb Bartosz Golaszewski 2023-06-19 633 RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
463120c31c58bb Bartosz Golaszewski 2023-06-19 634 RGMII_IO_MACRO_CONFIG2);
a818bd12538c14 Sneh Shah 2024-02-20 635 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 636 phy_set_speed(ethqos->serdes_phy, SPEED_1000);
a818bd12538c14 Sneh Shah 2024-02-20 637 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 638 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 639 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 640 case SPEED_100:
463120c31c58bb Bartosz Golaszewski 2023-06-19 641 val |= ETHQOS_MAC_CTRL_PORT_SEL | ETHQOS_MAC_CTRL_SPEED_MODE;
a818bd12538c14 Sneh Shah 2024-02-20 642 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 643 phy_set_speed(ethqos->serdes_phy, SPEED_1000);
a818bd12538c14 Sneh Shah 2024-02-20 644 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 645 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 646 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 647 case SPEED_10:
463120c31c58bb Bartosz Golaszewski 2023-06-19 648 val |= ETHQOS_MAC_CTRL_PORT_SEL;
463120c31c58bb Bartosz Golaszewski 2023-06-19 649 val &= ~ETHQOS_MAC_CTRL_SPEED_MODE;
981d947bcd382c Sneh Shah 2023-12-12 650 rgmii_updatel(ethqos, RGMII_CONFIG_SGMII_CLK_DVDR,
981d947bcd382c Sneh Shah 2023-12-12 651 FIELD_PREP(RGMII_CONFIG_SGMII_CLK_DVDR,
981d947bcd382c Sneh Shah 2023-12-12 652 SGMII_10M_RX_CLK_DVDR),
981d947bcd382c Sneh Shah 2023-12-12 653 RGMII_IO_MACRO_CONFIG);
a818bd12538c14 Sneh Shah 2024-02-20 654 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 655 phy_set_speed(ethqos->serdes_phy, ethqos->speed);
a818bd12538c14 Sneh Shah 2024-02-20 656 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 657 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 658 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 659 }
463120c31c58bb Bartosz Golaszewski 2023-06-19 660
463120c31c58bb Bartosz Golaszewski 2023-06-19 661 writel(val, ethqos->mac_base + MAC_CTRL_REG);
463120c31c58bb Bartosz Golaszewski 2023-06-19 662
463120c31c58bb Bartosz Golaszewski 2023-06-19 663 return val;
463120c31c58bb Bartosz Golaszewski 2023-06-19 664 }
463120c31c58bb Bartosz Golaszewski 2023-06-19 665
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code
[not found] <E1s6C4O-00Ck6O-9D@rmk-PC.armlinux.org.uk>
2024-05-13 5:15 ` [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code kernel test robot
@ 2024-05-25 4:24 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-05-25 4:24 UTC (permalink / raw)
To: Russell King (Oracle); +Cc: llvm, oe-kbuild-all
Hi Russell,
[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Russell-King-Oracle/net-stmmac-remove-pcs_ctrl_ane-method-and-associated-code/20240525-090556
base: net-next/main
patch link: https://lore.kernel.org/r/E1s6C4O-00Ck6O-9D%40rmk-PC.armlinux.org.uk
patch subject: [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240525/202405251257.hL6jMiJW-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240525/202405251257.hL6jMiJW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405251257.hL6jMiJW-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:628:3: error: implicit declaration of function 'stmmac_pcs_ctrl_ane' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0);
^
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:628:3: note: did you mean 'stmmac_pcs_clean'?
drivers/net/ethernet/stmicro/stmmac/stmmac.h:381:6: note: 'stmmac_pcs_clean' declared here
void stmmac_pcs_clean(struct net_device *ndev);
^
1 error generated.
vim +/stmmac_pcs_ctrl_ane +628 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
a7c30e62d4b895 Vinod Koul 2019-01-21 607
981d947bcd382c Sneh Shah 2023-12-12 608 /* On interface toggle MAC registers gets reset.
981d947bcd382c Sneh Shah 2023-12-12 609 * Configure MAC block for SGMII on ethernet phy link up
981d947bcd382c Sneh Shah 2023-12-12 610 */
463120c31c58bb Bartosz Golaszewski 2023-06-19 611 static int ethqos_configure_sgmii(struct qcom_ethqos *ethqos)
463120c31c58bb Bartosz Golaszewski 2023-06-19 612 {
a818bd12538c14 Sneh Shah 2024-02-20 613 struct net_device *dev = platform_get_drvdata(ethqos->pdev);
a818bd12538c14 Sneh Shah 2024-02-20 614 struct stmmac_priv *priv = netdev_priv(dev);
463120c31c58bb Bartosz Golaszewski 2023-06-19 615 int val;
463120c31c58bb Bartosz Golaszewski 2023-06-19 616
463120c31c58bb Bartosz Golaszewski 2023-06-19 617 val = readl(ethqos->mac_base + MAC_CTRL_REG);
463120c31c58bb Bartosz Golaszewski 2023-06-19 618
463120c31c58bb Bartosz Golaszewski 2023-06-19 619 switch (ethqos->speed) {
a818bd12538c14 Sneh Shah 2024-02-20 620 case SPEED_2500:
a818bd12538c14 Sneh Shah 2024-02-20 621 val &= ~ETHQOS_MAC_CTRL_PORT_SEL;
a818bd12538c14 Sneh Shah 2024-02-20 622 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
a818bd12538c14 Sneh Shah 2024-02-20 623 RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
a818bd12538c14 Sneh Shah 2024-02-20 624 RGMII_IO_MACRO_CONFIG2);
a818bd12538c14 Sneh Shah 2024-02-20 625 if (ethqos->serdes_speed != SPEED_2500)
a818bd12538c14 Sneh Shah 2024-02-20 626 phy_set_speed(ethqos->serdes_phy, SPEED_2500);
a818bd12538c14 Sneh Shah 2024-02-20 627 ethqos->serdes_speed = SPEED_2500;
a818bd12538c14 Sneh Shah 2024-02-20 @628 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 0, 0, 0);
a818bd12538c14 Sneh Shah 2024-02-20 629 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 630 case SPEED_1000:
463120c31c58bb Bartosz Golaszewski 2023-06-19 631 val &= ~ETHQOS_MAC_CTRL_PORT_SEL;
463120c31c58bb Bartosz Golaszewski 2023-06-19 632 rgmii_updatel(ethqos, RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
463120c31c58bb Bartosz Golaszewski 2023-06-19 633 RGMII_CONFIG2_RGMII_CLK_SEL_CFG,
463120c31c58bb Bartosz Golaszewski 2023-06-19 634 RGMII_IO_MACRO_CONFIG2);
a818bd12538c14 Sneh Shah 2024-02-20 635 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 636 phy_set_speed(ethqos->serdes_phy, SPEED_1000);
a818bd12538c14 Sneh Shah 2024-02-20 637 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 638 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 639 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 640 case SPEED_100:
463120c31c58bb Bartosz Golaszewski 2023-06-19 641 val |= ETHQOS_MAC_CTRL_PORT_SEL | ETHQOS_MAC_CTRL_SPEED_MODE;
a818bd12538c14 Sneh Shah 2024-02-20 642 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 643 phy_set_speed(ethqos->serdes_phy, SPEED_1000);
a818bd12538c14 Sneh Shah 2024-02-20 644 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 645 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 646 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 647 case SPEED_10:
463120c31c58bb Bartosz Golaszewski 2023-06-19 648 val |= ETHQOS_MAC_CTRL_PORT_SEL;
463120c31c58bb Bartosz Golaszewski 2023-06-19 649 val &= ~ETHQOS_MAC_CTRL_SPEED_MODE;
981d947bcd382c Sneh Shah 2023-12-12 650 rgmii_updatel(ethqos, RGMII_CONFIG_SGMII_CLK_DVDR,
981d947bcd382c Sneh Shah 2023-12-12 651 FIELD_PREP(RGMII_CONFIG_SGMII_CLK_DVDR,
981d947bcd382c Sneh Shah 2023-12-12 652 SGMII_10M_RX_CLK_DVDR),
981d947bcd382c Sneh Shah 2023-12-12 653 RGMII_IO_MACRO_CONFIG);
a818bd12538c14 Sneh Shah 2024-02-20 654 if (ethqos->serdes_speed != SPEED_1000)
a818bd12538c14 Sneh Shah 2024-02-20 655 phy_set_speed(ethqos->serdes_phy, ethqos->speed);
a818bd12538c14 Sneh Shah 2024-02-20 656 ethqos->serdes_speed = SPEED_1000;
a818bd12538c14 Sneh Shah 2024-02-20 657 stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, 0, 0);
463120c31c58bb Bartosz Golaszewski 2023-06-19 658 break;
463120c31c58bb Bartosz Golaszewski 2023-06-19 659 }
463120c31c58bb Bartosz Golaszewski 2023-06-19 660
463120c31c58bb Bartosz Golaszewski 2023-06-19 661 writel(val, ethqos->mac_base + MAC_CTRL_REG);
463120c31c58bb Bartosz Golaszewski 2023-06-19 662
463120c31c58bb Bartosz Golaszewski 2023-06-19 663 return val;
463120c31c58bb Bartosz Golaszewski 2023-06-19 664 }
463120c31c58bb Bartosz Golaszewski 2023-06-19 665
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-25 4:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1s6C4O-00Ck6O-9D@rmk-PC.armlinux.org.uk>
2024-05-13 5:15 ` [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code kernel test robot
2024-05-25 4:24 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox