Re: [RFC PATCH net-next] net/smc: Introduce a hook to modify syn_smc at runtime

Re: [RFC PATCH net-next] net/smc: Introduce a hook to modify syn_smc at runtime

[kernel test robot]

Hi Wythe,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/D-Wythe/net-smc-Introduce-a-hook-to-modify-syn_smc-at-runtime/20240918-181133
base:   net-next/main
patch link:    https://lore.kernel.org/r/1726654204-61655-1-git-send-email-alibuda%40linux.alibaba.com
patch subject: [RFC PATCH net-next] net/smc: Introduce a hook to modify syn_smc at runtime
config: i386-buildonly-randconfig-003-20240922 (https://download.01.org/0day-ci/archive/20240922/202409220838.lnpJlKYJ-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220838.lnpJlKYJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409220838.lnpJlKYJ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/smc/af_smc.c:194:36: error: no member named 'skc_v6_daddr' in 'struct sock_common'
     194 |                 rmt6_sockaddr->sin6_addr = ireq->ir_v6_rmt_addr;
         |                                            ~~~~~~^~~~~~~~~~~~~~
   include/net/inet_sock.h:74:42: note: expanded from macro 'ir_v6_rmt_addr'
      74 | #define ir_v6_rmt_addr          req.__req_common.skc_v6_daddr
         |                                                  ^
   1 error generated.


vim +194 net/smc/af_smc.c

   167	
   168	static void smc_openreq_init(struct request_sock *req,
   169				     const struct tcp_options_received *rx_opt,
   170				     struct sk_buff *skb, const struct sock *sk)
   171	{
   172		struct inet_request_sock *ireq = inet_rsk(req);
   173		struct sockaddr_storage rmt_sockaddr = {0};
   174		const struct smc_sock *smc;
   175	
   176		smc = smc_clcsock_user_data(sk);
   177	
   178		if (!smc)
   179			return;
   180	
   181		if (smc->limit_smc_hs && workqueue_congested(WORK_CPU_UNBOUND, smc_hs_wq))
   182			goto out_no_smc;
   183	
   184		rmt_sockaddr.ss_family = sk->sk_family;
   185	
   186		if (rmt_sockaddr.ss_family == AF_INET) {
   187			struct sockaddr_in *rmt4_sockaddr =  (struct sockaddr_in *)&rmt_sockaddr;
   188	
   189			rmt4_sockaddr->sin_addr.s_addr = ireq->ir_rmt_addr;
   190			rmt4_sockaddr->sin_port	= ireq->ir_rmt_port;
   191		} else {
   192			struct sockaddr_in6 *rmt6_sockaddr =  (struct sockaddr_in6 *)&rmt_sockaddr;
   193	
 > 194			rmt6_sockaddr->sin6_addr = ireq->ir_v6_rmt_addr;
   195			rmt6_sockaddr->sin6_port = ireq->ir_rmt_port;
   196		}
   197	
   198		ireq->smc_ok = select_syn_smc(sk, (struct sockaddr *)&rmt_sockaddr);
   199		return;
   200	out_no_smc:
   201		ireq->smc_ok = 0;
   202		return;
   203	}
   204	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [RFC PATCH net-next] net/smc: Introduce a hook to modify syn_smc at runtime

[kernel test robot]

Hi Wythe,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/D-Wythe/net-smc-Introduce-a-hook-to-modify-syn_smc-at-runtime/20240918-181133
base:   net-next/main
patch link:    https://lore.kernel.org/r/1726654204-61655-1-git-send-email-alibuda%40linux.alibaba.com
patch subject: [RFC PATCH net-next] net/smc: Introduce a hook to modify syn_smc at runtime
config: arm-randconfig-002-20240922 (https://download.01.org/0day-ci/archive/20240922/202409220912.ueH73mHB-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220912.ueH73mHB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409220912.ueH73mHB-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from net/smc/af_smc.c:27:
   In file included from include/linux/if_vlan.h:10:
   In file included from include/linux/netdevice.h:38:
   In file included from include/net/net_namespace.h:43:
   In file included from include/linux/skbuff.h:17:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:8:
   In file included from include/linux/cacheflush.h:5:
   In file included from arch/arm/include/asm/cacheflush.h:10:
   In file included from include/linux/mm.h:2232:
   include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     517 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   net/smc/af_smc.c:194:36: error: no member named 'skc_v6_daddr' in 'struct sock_common'
     194 |                 rmt6_sockaddr->sin6_addr = ireq->ir_v6_rmt_addr;
         |                                            ~~~~~~^~~~~~~~~~~~~~
   include/net/inet_sock.h:74:42: note: expanded from macro 'ir_v6_rmt_addr'
      74 | #define ir_v6_rmt_addr          req.__req_common.skc_v6_daddr
         |                                                  ^
>> net/smc/af_smc.c:3519:9: error: call to undeclared function 'register_btf_fmodret_id_set'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    3519 |         return register_btf_fmodret_id_set(&bpf_smc_fmodret_set);
         |                ^
   net/smc/af_smc.c:3519:9: note: did you mean 'register_btf_kfunc_id_set'?
   include/linux/btf.h:623:19: note: 'register_btf_kfunc_id_set' declared here
     623 | static inline int register_btf_kfunc_id_set(enum bpf_prog_type prog_type,
         |                   ^
   1 warning and 2 errors generated.


vim +/register_btf_fmodret_id_set +3519 net/smc/af_smc.c

  3516	
  3517	static int __init bpf_smc_kfunc_init(void)
  3518	{
> 3519		return register_btf_fmodret_id_set(&bpf_smc_fmodret_set);
  3520	}
  3521	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki