* Re: [PATCH v2 2/2] genirq: Add kunit tests for depth counts [not found] <20250514201353.3481400-3-briannorris@chromium.org> @ 2025-05-15 14:01 ` kernel test robot 2025-05-15 17:21 ` Brian Norris 0 siblings, 1 reply; 3+ messages in thread From: kernel test robot @ 2025-05-15 14:01 UTC (permalink / raw) To: Brian Norris, Thomas Gleixner Cc: llvm, oe-kbuild-all, Tsai Sung-Fu, Douglas Anderson, linux-kernel, Brian Norris Hi Brian, kernel test robot noticed the following build errors: [auto build test ERROR on tip/irq/core] [also build test ERROR on linus/master v6.15-rc6 next-20250515] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Brian-Norris/genirq-Retain-depth-for-managed-IRQs-across-CPU-hotplug/20250515-041533 base: tip/irq/core patch link: https://lore.kernel.org/r/20250514201353.3481400-3-briannorris%40chromium.org patch subject: [PATCH v2 2/2] genirq: Add kunit tests for depth counts config: i386-buildonly-randconfig-004-20250515 (https://download.01.org/0day-ci/archive/20250515/202505152136.y04AHovS-lkp@intel.com/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505152136.y04AHovS-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202505152136.y04AHovS-lkp@intel.com/ All errors (new ones prefixed by >>, old ones prefixed by <<): WARNING: modpost: missing MODULE_DESCRIPTION() in lib/ucs2_string.o ERROR: modpost: "irq_domain_alloc_descs" [kernel/irq/irq_test.ko] undefined! ERROR: modpost: "irq_to_desc" [kernel/irq/irq_test.ko] undefined! ERROR: modpost: "irq_shutdown_and_deactivate" [kernel/irq/irq_test.ko] undefined! >> ERROR: modpost: "irq_activate" [kernel/irq/irq_test.ko] undefined! >> ERROR: modpost: "irq_startup_managed" [kernel/irq/irq_test.ko] undefined! -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] genirq: Add kunit tests for depth counts 2025-05-15 14:01 ` [PATCH v2 2/2] genirq: Add kunit tests for depth counts kernel test robot @ 2025-05-15 17:21 ` Brian Norris 2025-05-15 22:24 ` Thomas Gleixner 0 siblings, 1 reply; 3+ messages in thread From: Brian Norris @ 2025-05-15 17:21 UTC (permalink / raw) To: Thomas Gleixner Cc: Thomas Gleixner, llvm, oe-kbuild-all, Tsai Sung-Fu, Douglas Anderson, linux-kernel, kernel test robot Hi Thomas, On Thu, May 15, 2025 at 10:01:18PM +0800, kernel test robot wrote: > patch link: https://lore.kernel.org/r/20250514201353.3481400-3-briannorris%40chromium.org > patch subject: [PATCH v2 2/2] genirq: Add kunit tests for depth counts First of all, thanks for the help, and for applying patch 1. I see that: 1) this bot noticed a trivial problem with patch 2; and 2) I received notification that patch 2 was applied to tip/irq/core, but 3) I can't find it there any more. I'm not sure if #3 is because you dropped it (e.g., due to #1's report) or some other reason, so I'm not sure what to do next. Possibilities: (a) send the trivial fix separately, as a fixup (against what tree?) (b) resend an improved patch 2 on its own, against tip/irq/core (c) just drop it, because you have deeper reasons to not want these tests. I'm fine with anything you'd like, although I do think there's value in providing unit tests for corner cases like this. See below for the trivial fix, for the record. I can send it separately if you'd like. > config: i386-buildonly-randconfig-004-20250515 (https://download.01.org/0day-ci/archive/20250515/202505152136.y04AHovS-lkp@intel.com/config) > compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250515/202505152136.y04AHovS-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202505152136.y04AHovS-lkp@intel.com/ > > All errors (new ones prefixed by >>, old ones prefixed by <<): > > WARNING: modpost: missing MODULE_DESCRIPTION() in lib/ucs2_string.o > ERROR: modpost: "irq_domain_alloc_descs" [kernel/irq/irq_test.ko] undefined! > ERROR: modpost: "irq_to_desc" [kernel/irq/irq_test.ko] undefined! > ERROR: modpost: "irq_shutdown_and_deactivate" [kernel/irq/irq_test.ko] undefined! > >> ERROR: modpost: "irq_activate" [kernel/irq/irq_test.ko] undefined! > >> ERROR: modpost: "irq_startup_managed" [kernel/irq/irq_test.ko] undefined! The test Kconfig symbol should be bool, not tristate. Some of the functions required for the test are non-modular. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202505152136.y04AHovS-lkp@intel.com/ Signed-off-by: Brian Norris <briannorris@chromium.org> --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -145,7 +145,7 @@ config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD bool config IRQ_KUNIT_TEST - tristate "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS + bool "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS depends on KUNIT default KUNIT_ALL_TESTS imply SMP ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] genirq: Add kunit tests for depth counts 2025-05-15 17:21 ` Brian Norris @ 2025-05-15 22:24 ` Thomas Gleixner 0 siblings, 0 replies; 3+ messages in thread From: Thomas Gleixner @ 2025-05-15 22:24 UTC (permalink / raw) To: Brian Norris Cc: llvm, oe-kbuild-all, Tsai Sung-Fu, Douglas Anderson, linux-kernel, kernel test robot On Thu, May 15 2025 at 10:21, Brian Norris wrote: > On Thu, May 15, 2025 at 10:01:18PM +0800, kernel test robot wrote: >> patch link: https://lore.kernel.org/r/20250514201353.3481400-3-briannorris%40chromium.org >> patch subject: [PATCH v2 2/2] genirq: Add kunit tests for depth counts > > First of all, thanks for the help, and for applying patch 1. I see that: > 1) this bot noticed a trivial problem with patch 2; and > 2) I received notification that patch 2 was applied to tip/irq/core, but > 3) I can't find it there any more. > > I'm not sure if #3 is because you dropped it (e.g., due to #1's report) > or some other reason, so I'm not sure what to do next. Possibilities: #3 because I dropped it. > (a) send the trivial fix separately, as a fixup (against what tree?) > (b) resend an improved patch 2 on its own, against tip/irq/core > (c) just drop it, because you have deeper reasons to not want these > tests. #b please Thanks, tglx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-15 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250514201353.3481400-3-briannorris@chromium.org>
2025-05-15 14:01 ` [PATCH v2 2/2] genirq: Add kunit tests for depth counts kernel test robot
2025-05-15 17:21 ` Brian Norris
2025-05-15 22:24 ` Thomas Gleixner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox