[driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function

[driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git driver-core-testing
head:   86a5f32ed8813d5534d3d6c77aad29184a9f99b6
commit: 86a5f32ed8813d5534d3d6c77aad29184a9f99b6 [29/29] drivers: base: test: Add ...find_device_by...(... NULL) tests
config: i386-buildonly-randconfig-003-20241224 (https://download.01.org/0day-ci/archive/20241224/202412241917.orLfjA92-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241224/202412241917.orLfjA92-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412241917.orLfjA92-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/base/test/platform-device-test.c:3:
>> include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function [-Wvisibility]
      15 |                                                  struct completion *x);
         |                                                         ^
   1 warning generated.


vim +15 include/kunit/platform_device.h

5ac79730324c6f Stephen Boyd 2024-07-18  12  
5ac79730324c6f Stephen Boyd 2024-07-18  13  int kunit_platform_device_prepare_wait_for_probe(struct kunit *test,
5ac79730324c6f Stephen Boyd 2024-07-18  14  						 struct platform_device *pdev,
5ac79730324c6f Stephen Boyd 2024-07-18 @15  						 struct completion *x);
5ac79730324c6f Stephen Boyd 2024-07-18  16  

:::::: The code at line 15 was first introduced by commit
:::::: 5ac79730324c6f37106ce397586020ffe6e8e234 platform: Add test managed platform_device/driver APIs

:::::: TO: Stephen Boyd <sboyd@kernel.org>
:::::: CC: Stephen Boyd <sboyd@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function

[Brian Norris]

On Tue, Dec 24, 2024 at 07:37:20PM +0800, kernel test robot wrote:
> All warnings (new ones prefixed by >>):
> 
>    In file included from drivers/base/test/platform-device-test.c:3:
> >> include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function [-Wvisibility]
>       15 |                                                  struct completion *x);
>          |                                                         ^
>    1 warning generated.

Same:

https://lore.kernel.org/lkml/20241213180841.3023843-1-briannorris@chromium.org/
Subject: [PATCH] kunit: platform: Resolve 'struct completion' warning

Brian

Re: [driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function

[Greg Kroah-Hartman]

On Thu, Jan 02, 2025 at 10:39:11AM -0800, Brian Norris wrote:
> On Tue, Dec 24, 2024 at 07:37:20PM +0800, kernel test robot wrote:
> > All warnings (new ones prefixed by >>):
> > 
> >    In file included from drivers/base/test/platform-device-test.c:3:
> > >> include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function [-Wvisibility]
> >       15 |                                                  struct completion *x);
> >          |                                                         ^
> >    1 warning generated.
> 
> Same:
> 
> https://lore.kernel.org/lkml/20241213180841.3023843-1-briannorris@chromium.org/
> Subject: [PATCH] kunit: platform: Resolve 'struct completion' warning

I guess it should have been cc:ed me.  I'll go dig it up now...

thanks,

greg k-h

Re: [driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function

[Brian Norris]

On Fri, Jan 03, 2025 at 04:52:01PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jan 02, 2025 at 10:39:11AM -0800, Brian Norris wrote:
> > On Tue, Dec 24, 2024 at 07:37:20PM +0800, kernel test robot wrote:
> > > All warnings (new ones prefixed by >>):
> > > 
> > >    In file included from drivers/base/test/platform-device-test.c:3:
> > > >> include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function [-Wvisibility]
> > >       15 |                                                  struct completion *x);
> > >          |                                                         ^
> > >    1 warning generated.
> > 
> > Same:
> > 
> > https://lore.kernel.org/lkml/20241213180841.3023843-1-briannorris@chromium.org/
> > Subject: [PATCH] kunit: platform: Resolve 'struct completion' warning
> 
> I guess it should have been cc:ed me.  I'll go dig it up now...

I sent it where get_maintainer pointed me:

$ scripts/get_maintainer.pl -f include/kunit/platform_device.h
Brendan Higgins <brendan.higgins@linux.dev> (maintainer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
David Gow <davidgow@google.com> (maintainer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
Rae Moar <rmoar@google.com> (reviewer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
linux-kselftest@vger.kernel.org (open list:KERNEL UNIT TESTING FRAMEWORK (KUnit))
kunit-dev@googlegroups.com (open list:KERNEL UNIT TESTING FRAMEWORK (KUnit))
linux-kernel@vger.kernel.org (open list)

Anyway, thanks for picking it up.

Brian

Re: [driver-core:driver-core-testing 29/29] include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function

[Greg Kroah-Hartman]

On Fri, Jan 03, 2025 at 09:49:35AM -0800, Brian Norris wrote:
> On Fri, Jan 03, 2025 at 04:52:01PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Jan 02, 2025 at 10:39:11AM -0800, Brian Norris wrote:
> > > On Tue, Dec 24, 2024 at 07:37:20PM +0800, kernel test robot wrote:
> > > > All warnings (new ones prefixed by >>):
> > > > 
> > > >    In file included from drivers/base/test/platform-device-test.c:3:
> > > > >> include/kunit/platform_device.h:15:15: warning: declaration of 'struct completion' will not be visible outside of this function [-Wvisibility]
> > > >       15 |                                                  struct completion *x);
> > > >          |                                                         ^
> > > >    1 warning generated.
> > > 
> > > Same:
> > > 
> > > https://lore.kernel.org/lkml/20241213180841.3023843-1-briannorris@chromium.org/
> > > Subject: [PATCH] kunit: platform: Resolve 'struct completion' warning
> > 
> > I guess it should have been cc:ed me.  I'll go dig it up now...
> 
> I sent it where get_maintainer pointed me:
> 
> $ scripts/get_maintainer.pl -f include/kunit/platform_device.h
> Brendan Higgins <brendan.higgins@linux.dev> (maintainer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> David Gow <davidgow@google.com> (maintainer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> Rae Moar <rmoar@google.com> (reviewer:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> linux-kselftest@vger.kernel.org (open list:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> kunit-dev@googlegroups.com (open list:KERNEL UNIT TESTING FRAMEWORK (KUnit))
> linux-kernel@vger.kernel.org (open list)

That's good, but you also need to send it to the maintainer that owns
the git tree where the bug is showing up in :)

Something to remember for future stuff, thanks!

greg k-h