* [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2
@ 2009-06-30 7:42 naresh kamboju
2009-06-30 10:46 ` Kamalesh Babulal
2009-06-30 11:12 ` Subrata Modak
0 siblings, 2 replies; 6+ messages in thread
From: naresh kamboju @ 2009-06-30 7:42 UTC (permalink / raw)
To: ltp-list; +Cc: Brandon Philips, maxin john, Manas Kumar Nayak
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
Hi,
I have noticed failure under open_posix_testsuite for
mq_unlink/speculative/7-2.c and fixed.
After changing the uninitialized to initialized char array of mqname[]
test case got PASSED.
I have attached patch and below.
Please review the same.
Best Regards
Naresh Kamboju
Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
--- a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
2005-06-03 22:00:59.000000000 +0530
+++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
2009-06-30 12:37:35.000000000 +0530
@@ -28,7 +28,7 @@
int main()
{
- char mqname[50];
+ char mqname[50]="/123";
// sprintf(mqname, FUNCTION "_" TEST "_%d", getpid());
[-- Attachment #2: ltp-mq_unlink_speculative_7-2.patch --]
[-- Type: application/octet-stream, Size: 568 bytes --]
diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
--- a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c 2005-06-03 22:00:59.000000000 +0530
+++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c 2009-06-30 12:37:35.000000000 +0530
@@ -28,7 +28,7 @@
int main()
{
- char mqname[50];
+ char mqname[50]="/123";
// sprintf(mqname, FUNCTION "_" TEST "_%d", getpid());
[-- Attachment #3: Type: text/plain, Size: 79 bytes --]
------------------------------------------------------------------------------
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2
2009-06-30 7:42 [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2 naresh kamboju
@ 2009-06-30 10:46 ` Kamalesh Babulal
2009-06-30 11:12 ` Subrata Modak
1 sibling, 0 replies; 6+ messages in thread
From: Kamalesh Babulal @ 2009-06-30 10:46 UTC (permalink / raw)
To: naresh kamboju; +Cc: ltp-list, Brandon Philips, maxin john, Manas Kumar Nayak
* naresh kamboju <naresh.kernel@gmail.com> [2009-06-30 13:12:57]:
> Hi,
>
> I have noticed failure under open_posix_testsuite for
> mq_unlink/speculative/7-2.c and fixed.
> After changing the uninitialized to initialized char array of mqname[]
> test case got PASSED.
>
> I have attached patch and below.
> Please review the same.
>
>
> Best Regards
> Naresh Kamboju
looks good to me.
>
> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
>
>
> diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> 2005-06-03 22:00:59.000000000 +0530
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> 2009-06-30 12:37:35.000000000 +0530
> @@ -28,7 +28,7 @@
>
> int main()
> {
> - char mqname[50];
> + char mqname[50]="/123";
>
> // sprintf(mqname, FUNCTION "_" TEST "_%d", getpid());
Kamalesh
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2
2009-06-30 7:42 [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2 naresh kamboju
2009-06-30 10:46 ` Kamalesh Babulal
@ 2009-06-30 11:12 ` Subrata Modak
2009-07-01 8:46 ` naresh kamboju
1 sibling, 1 reply; 6+ messages in thread
From: Subrata Modak @ 2009-06-30 11:12 UTC (permalink / raw)
To: naresh kamboju; +Cc: ltp-list, Brandon Philips, maxin john, Manas Kumar Nayak
Hi Naresh,
On Tue, 2009-06-30 at 13:12 +0530, naresh kamboju wrote:
> Hi,
>
> I have noticed failure under open_posix_testsuite for
> mq_unlink/speculative/7-2.c and fixed.
> After changing the uninitialized to initialized char array of mqname[]
> test case got PASSED.
Great. Could you also please share with us the test results before and
after this patch ?
Regards--
Subrata
>
> I have attached patch and below.
> Please review the same.
>
>
> Best Regards
> Naresh Kamboju
>
> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
>
>
> diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> 2005-06-03 22:00:59.000000000 +0530
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> 2009-06-30 12:37:35.000000000 +0530
> @@ -28,7 +28,7 @@
>
> int main()
> {
> - char mqname[50];
> + char mqname[50]="/123";
>
> // sprintf(mqname, FUNCTION "_" TEST "_%d", getpid());
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2
2009-06-30 11:12 ` Subrata Modak
@ 2009-07-01 8:46 ` naresh kamboju
2009-07-01 13:13 ` Subrata Modak
0 siblings, 1 reply; 6+ messages in thread
From: naresh kamboju @ 2009-07-01 8:46 UTC (permalink / raw)
To: subrata; +Cc: ltp-list, Brandon Philips, maxin john, Manas Kumar Nayak
On Tue, Jun 30, 2009 at 4:42 PM, Subrata
Modak<subrata@linux.vnet.ibm.com> wrote:
> Hi Naresh,
>
> On Tue, 2009-06-30 at 13:12 +0530, naresh kamboju wrote:
>> Hi,
>>
>> I have noticed failure under open_posix_testsuite for
>> mq_unlink/speculative/7-2.c and fixed.
>> After changing the uninitialized to initialized char array of mqname[]
>> test case got PASSED.
>
> Great. Could you also please share with us the test results before and
> after this patch ?
Before patch Results:
conformance/interfaces/mq_unlink/speculative/7-2: execution: FAILED
# ./7-2.test
Test FAILED, error is Invalid argument
After patch Results:
conformance/interfaces/mq_unlink/speculative/7-2: execution: PASS
# ./7-2.test
Test PASSED
Best regards,
Naresh Kamboju
>
> Regards--
> Subrata
>
>>
>> I have attached patch and below.
>> Please review the same.
>>
>>
>> Best Regards
>> Naresh Kamboju
>>
>> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
>>
>>
>> diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
>> b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
>> --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
>> 2005-06-03 22:00:59.000000000 +0530
>> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
>> 2009-06-30 12:37:35.000000000 +0530
>> @@ -28,7 +28,7 @@
>>
>> int main()
>> {
>> - char mqname[50];
>> + char mqname[50]="/123";
>>
>> // sprintf(mqname, FUNCTION "_" TEST "_%d", getpid());
>
>
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2
2009-07-01 8:46 ` naresh kamboju
@ 2009-07-01 13:13 ` Subrata Modak
2009-07-01 13:33 ` naresh kamboju
0 siblings, 1 reply; 6+ messages in thread
From: Subrata Modak @ 2009-07-01 13:13 UTC (permalink / raw)
To: naresh kamboju; +Cc: ltp-list, Brandon Philips, maxin john, Manas Kumar Nayak
On Wed, 2009-07-01 at 14:16 +0530, naresh kamboju wrote:
> On Tue, Jun 30, 2009 at 4:42 PM, Subrata
> Modak<subrata@linux.vnet.ibm.com> wrote:
> > Hi Naresh,
> >
> > On Tue, 2009-06-30 at 13:12 +0530, naresh kamboju wrote:
> >> Hi,
> >>
> >> I have noticed failure under open_posix_testsuite for
> >> mq_unlink/speculative/7-2.c and fixed.
> >> After changing the uninitialized to initialized char array of mqname[]
> >> test case got PASSED.
> >
> > Great. Could you also please share with us the test results before and
> > after this patch ?
>
> Before patch Results:
>
> conformance/interfaces/mq_unlink/speculative/7-2: execution: FAILED
> # ./7-2.test
> Test FAILED, error is Invalid argument
>
> After patch Results:
>
> conformance/interfaces/mq_unlink/speculative/7-2: execution: PASS
> # ./7-2.test
> Test PASSED
Thanks. What better way to start July to checkin your patch.
Regards--
Subrata
>
>
> Best regards,
> Naresh Kamboju
>
> >
> > Regards--
> > Subrata
> >
> >>
> >> I have attached patch and below.
> >> Please review the same.
> >>
> >>
> >> Best Regards
> >> Naresh Kamboju
> >>
> >> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
> >>
> >>
> >> diff -Naurb a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> >> b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> >> --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> >> 2005-06-03 22:00:59.000000000 +0530
> >> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_unlink/speculative/7-2.c
> >> 2009-06-30 12:37:35.000000000 +0530
> >> @@ -28,7 +28,7 @@
> >>
> >> int main()
> >> {
> >> - char mqname[50];
> >> + char mqname[50]="/123";
> >>
> >> // sprintf(mqname, FUNCTION "_" TEST "_%d", getpid());
> >
> >
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2
2009-07-01 13:13 ` Subrata Modak
@ 2009-07-01 13:33 ` naresh kamboju
0 siblings, 0 replies; 6+ messages in thread
From: naresh kamboju @ 2009-07-01 13:33 UTC (permalink / raw)
To: subrata; +Cc: ltp-list, Brandon Philips, maxin john, Manas Kumar Nayak
>> >> After changing the uninitialized to initialized char array of mqname[]
>> >> test case got PASSED.
>> >
>> After patch Results:
>>
>> conformance/interfaces/mq_unlink/speculative/7-2: execution: PASS
>> # ./7-2.test
>> Test PASSED
>
> Thanks. What better way to start July to checkin your patch.
Great News
Thank you... :-)
Best Regards
Naresh Kamboju
>
> Regards--
> Subrata
>
>>
>>
>> Best regards,
>> Naresh Kamboju
>>
>> >
>> >>
>> >>
>> >> Signed-off-by: Naresh Kamboju < naresh.kernel@gmail.com >
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-07-01 14:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-30 7:42 [LTP] [FIX PATCHES] ltp-mq_unlink_speculative_7-2 naresh kamboju
2009-06-30 10:46 ` Kamalesh Babulal
2009-06-30 11:12 ` Subrata Modak
2009-07-01 8:46 ` naresh kamboju
2009-07-01 13:13 ` Subrata Modak
2009-07-01 13:33 ` naresh kamboju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox