From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 5/5] Adopt doc for TST_RETRY_FUNC for LTP_TIMEOUT_MUL
Date: Mon, 21 Oct 2019 15:15:30 +0200 [thread overview]
Message-ID: <20191021131530.GB18513@x230> (raw)
In-Reply-To: <87h842o2pp.fsf@rpws.prws.suse.cz>
Hi,
> Clemens Famulla-Conrad <cfamullaconrad@suse.de> writes:
> > Mention that time limit is mulitplied with LTP_TIMEOUT_MUL.
> > ---
> > doc/test-writing-guidelines.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > diff --git a/doc/test-writing-guidelines.txt b/doc/test-writing-guidelines.txt
> > index efff4d40c..905a4baa5 100644
> > --- a/doc/test-writing-guidelines.txt
> > +++ b/doc/test-writing-guidelines.txt
> > @@ -2313,7 +2313,8 @@ Retry a function in limited time
> > Sometimes LTP test needs retrying a function for many times to get success.
> > This achievement makes that possible via keeping it retrying if the return
> > value of the function is NOT as we expected. After exceeding a limited time,
> > -test will break from the retries immediately.
> > +test will break from the retries immediately. The time limit is multiplied
> > +with LTP_TIMEOUT_MUL.
> I think the function tst_multiply_timeout also needs documenting.
Isn't it meant to be used just in library (in lib/tst_test.c)?
Thus I wouldn't document it here. And in fact remove it from include/tst_test.h
(second commit).
Kind regards,
Petr
next prev parent reply other threads:[~2019-10-21 13:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:44 [LTP] [PATCH v4 0/5] tst_test.sh: Use LTP_TIMEOUT_MUL in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 1/5] " Clemens Famulla-Conrad
2019-10-21 12:42 ` Petr Vorel
2019-10-21 14:18 ` Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 2/5] tst_test.c: Add tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 12:50 ` Petr Vorel
2019-10-21 14:17 ` Clemens Famulla-Conrad
2019-10-21 14:42 ` Petr Vorel
2019-10-22 13:14 ` Petr Vorel
2019-10-21 14:37 ` Cyril Hrubis
2019-10-21 15:31 ` Clemens Famulla-Conrad
2019-10-21 18:08 ` Petr Vorel
2019-10-18 12:45 ` [LTP] [PATCH v4 3/5] tst_common.h: Use tst_multiply_timeout in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-21 14:38 ` Cyril Hrubis
2019-10-18 12:45 ` [LTP] [PATCH v4 4/5] Add newlib shell test for tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 9:28 ` Li Wang
2019-10-22 8:08 ` Petr Vorel
2019-10-22 12:31 ` Clemens Famulla-Conrad
2019-10-18 12:45 ` [LTP] [PATCH v4 5/5] Adopt doc for TST_RETRY_FUNC for LTP_TIMEOUT_MUL Clemens Famulla-Conrad
2019-10-21 9:41 ` Richard Palethorpe
2019-10-21 13:15 ` Petr Vorel [this message]
2019-10-21 13:41 ` Clemens Famulla-Conrad
2019-10-21 13:53 ` Petr Vorel
2019-10-21 14:46 ` Cyril Hrubis
2019-10-21 18:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021131530.GB18513@x230 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox