From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 4/5] Add newlib shell test for tst_multiply_timeout()
Date: Tue, 22 Oct 2019 10:08:31 +0200 [thread overview]
Message-ID: <20191022080830.GA17235@dell5510> (raw)
In-Reply-To: <20191018124502.25599-5-cfamullaconrad@suse.de>
Hi,
> +do_test()
> +{
> + LTP_TIMEOUT_MUL=2
> + local sec=1
> +
> + call_it 'tst_multiply_timeout sec' 'sec' 2
still some issue with this patchset. Making the function private
(_tst_multiply_timeout), we obviously get warning:
test_timeout_mul 1 TWARN: Private variable or function _tst_multiply_timeout used!
Unless we want to to add some special variable for library tests
(i.e. TST_IGNORE_WARN), the function cannot be used directly
I suggest to push the patchset change to use float (not to be postponed even
more), but without this patchset. Tests should be later added.
Kind regards,
Petr
> + sec=1
> + LTP_TIMEOUT_MUL="1.5"
> + call_it 'tst_multiply_timeout sec' 'sec' 2
> +
> + sec=1
> + LTP_TIMEOUT_MUL=0.5
> + call_it 'tst_multiply_timeout sec' 'sec' 1
> +
> + sec=1
> + LTP_TIMEOUT_MUL=2
> + call_it 'tst_multiply_timeout sec' 'sec' 2
> + call_it 'tst_multiply_timeout sec' 'sec' 4
> + call_it 'tst_multiply_timeout sec' 'sec' 8
> +}
> +
> +tst_run
next prev parent reply other threads:[~2019-10-22 8:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:44 [LTP] [PATCH v4 0/5] tst_test.sh: Use LTP_TIMEOUT_MUL in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 1/5] " Clemens Famulla-Conrad
2019-10-21 12:42 ` Petr Vorel
2019-10-21 14:18 ` Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 2/5] tst_test.c: Add tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 12:50 ` Petr Vorel
2019-10-21 14:17 ` Clemens Famulla-Conrad
2019-10-21 14:42 ` Petr Vorel
2019-10-22 13:14 ` Petr Vorel
2019-10-21 14:37 ` Cyril Hrubis
2019-10-21 15:31 ` Clemens Famulla-Conrad
2019-10-21 18:08 ` Petr Vorel
2019-10-18 12:45 ` [LTP] [PATCH v4 3/5] tst_common.h: Use tst_multiply_timeout in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-21 14:38 ` Cyril Hrubis
2019-10-18 12:45 ` [LTP] [PATCH v4 4/5] Add newlib shell test for tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 9:28 ` Li Wang
2019-10-22 8:08 ` Petr Vorel [this message]
2019-10-22 12:31 ` Clemens Famulla-Conrad
2019-10-18 12:45 ` [LTP] [PATCH v4 5/5] Adopt doc for TST_RETRY_FUNC for LTP_TIMEOUT_MUL Clemens Famulla-Conrad
2019-10-21 9:41 ` Richard Palethorpe
2019-10-21 13:15 ` Petr Vorel
2019-10-21 13:41 ` Clemens Famulla-Conrad
2019-10-21 13:53 ` Petr Vorel
2019-10-21 14:46 ` Cyril Hrubis
2019-10-21 18:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022080830.GA17235@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox