From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 2/5] tst_test.c: Add tst_multiply_timeout()
Date: Mon, 21 Oct 2019 16:37:03 +0200 [thread overview]
Message-ID: <20191021143703.GA27848@rei> (raw)
In-Reply-To: <20191018124502.25599-3-cfamullaconrad@suse.de>
Hi!
> + if (timeout_mul == -1) {
> + mul = getenv("LTP_TIMEOUT_MUL");
> + if (mul) {
> + timeout_mul = mul_float = atof(mul);
> + if (timeout_mul != mul_float) {
> + timeout_mul++;
> + tst_res(TINFO, "ceiling LTP_TIMEOUT_MUL to %d",
> + timeout_mul);
> + }
Huh, why are we ceiling the timeout multiplier?
We do that for shell because it simplifies the code and we do not care
that much about being precise for timeouts, but it does not make much
sense here.
Why can't we just convert the env variable to float and multiply?
Something as:
if (mul) {
if (ret = tst_parse_float(mul, &timeout_mul, 1, 10000)) {
tst_brk(TBROK, "Failed to parse LTP_TIMEOUT_MUL: %s",
tst_strerrno(ret));
}
} else {
timeout_mul = 1;
}
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2019-10-21 14:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:44 [LTP] [PATCH v4 0/5] tst_test.sh: Use LTP_TIMEOUT_MUL in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 1/5] " Clemens Famulla-Conrad
2019-10-21 12:42 ` Petr Vorel
2019-10-21 14:18 ` Clemens Famulla-Conrad
2019-10-18 12:44 ` [LTP] [PATCH v4 2/5] tst_test.c: Add tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 12:50 ` Petr Vorel
2019-10-21 14:17 ` Clemens Famulla-Conrad
2019-10-21 14:42 ` Petr Vorel
2019-10-22 13:14 ` Petr Vorel
2019-10-21 14:37 ` Cyril Hrubis [this message]
2019-10-21 15:31 ` Clemens Famulla-Conrad
2019-10-21 18:08 ` Petr Vorel
2019-10-18 12:45 ` [LTP] [PATCH v4 3/5] tst_common.h: Use tst_multiply_timeout in TST_RETRY_FN() Clemens Famulla-Conrad
2019-10-21 14:38 ` Cyril Hrubis
2019-10-18 12:45 ` [LTP] [PATCH v4 4/5] Add newlib shell test for tst_multiply_timeout() Clemens Famulla-Conrad
2019-10-21 9:28 ` Li Wang
2019-10-22 8:08 ` Petr Vorel
2019-10-22 12:31 ` Clemens Famulla-Conrad
2019-10-18 12:45 ` [LTP] [PATCH v4 5/5] Adopt doc for TST_RETRY_FUNC for LTP_TIMEOUT_MUL Clemens Famulla-Conrad
2019-10-21 9:41 ` Richard Palethorpe
2019-10-21 13:15 ` Petr Vorel
2019-10-21 13:41 ` Clemens Famulla-Conrad
2019-10-21 13:53 ` Petr Vorel
2019-10-21 14:46 ` Cyril Hrubis
2019-10-21 18:10 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021143703.GA27848@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox