From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported
Date: Wed, 30 Sep 2020 11:10:21 +0200 [thread overview]
Message-ID: <20200930091021.GA21717@dell5510> (raw)
In-Reply-To: <87v9fwx0re.fsf@suse.de>
Hi,
> Yang Xu <xuyang2018.jy@cn.fujitsu.com> writes:
> > Hi Petr
> >> Hi Yang,
> >>> Hi Petr
> >>> Why not using kconfig in tst_test struct.
> >> We should probably use tst_syscall().
> >> But using kconfig is not 1) needed (tst_syscall() most reliable way) 2) kconfig
> >> requires having kernel config available, which is not on some platforms.
> > I see. At the first, I prefer to like to use kconfig because it only
> > tests io_destory one time on kernel without CONFIG_AIO when we use -i
> > parameters, but using libaio wrapper is stable. So it is ok.
> Kconfig can even be wrong (most likely with out-of-tree patches) or we
> might look at the wrong option as things are moved around
> sometimes. This is another instance of us trying to guess if something
> can be done without trying it.
> I guess there are some things where it is not as simple as trying a
> system call, but in cases where ENOSYS will be returned there is no need
> to look at the config except maybe for diagnostic purposes. If you are
> concerned about '-i' then you can even just make in invalid syscall in
> setup to see what error it returns.
@Yang: Yes, have a look at various foo_supported_by_kernel() helper functions in
include/lapi/ (added by Viresh Kumar).
Kind regards,
Petr
next prev parent reply other threads:[~2020-09-30 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:35 [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported Petr Vorel
2020-09-29 7:41 ` Yang Xu
2020-09-29 8:41 ` Petr Vorel
2020-09-29 9:57 ` Yang Xu
2020-09-29 11:47 ` Richard Palethorpe
2020-09-30 9:10 ` Petr Vorel [this message]
2020-09-29 13:02 ` Cyril Hrubis
2020-09-29 8:38 ` Cyril Hrubis
2020-09-29 8:48 ` Petr Vorel
2020-09-29 8:51 ` Cyril Hrubis
2020-09-29 9:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930091021.GA21717@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox