From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported
Date: Tue, 29 Sep 2020 17:57:21 +0800 [thread overview]
Message-ID: <5F730501.7050505@cn.fujitsu.com> (raw)
In-Reply-To: <20200929084114.GA7482@dell5510>
Hi Petr
> Hi Yang,
>
>> Hi Petr
>> Why not using kconfig in tst_test struct.
>
> We should probably use tst_syscall().
> But using kconfig is not 1) needed (tst_syscall() most reliable way) 2) kconfig
> requires having kernel config available, which is not on some platforms.
I see. At the first, I prefer to like to use kconfig because it only
tests io_destory one time on kernel without CONFIG_AIO when we use -i
parameters, but using libaio wrapper is stable. So it is ok.
>
> (I plan to introduce TWARN_IF_NO_CONFIG to print only warning for platforms
> which don't have kconfig available, see
> https://github.com/linux-test-project/ltp/issues/700).
I have seen this ticket, if I understand it corretly,
if platform has kernel config without needed kconfig, test cases still
will report TCONF
if platform doesn't have kernel config, test cases only reports
warning(system doesn't have kernel config file) and continue to run test
and it maybe lead to a unexpected stat/failure. And we don't add extra
check in tests case such as ENOSYS/EINVAL check because it is redundant
against kconfig check.
Best Regards
Yang Xu
>
> Kind regards,
> Petr
>
>
> .
>
next prev parent reply other threads:[~2020-09-29 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:35 [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported Petr Vorel
2020-09-29 7:41 ` Yang Xu
2020-09-29 8:41 ` Petr Vorel
2020-09-29 9:57 ` Yang Xu [this message]
2020-09-29 11:47 ` Richard Palethorpe
2020-09-30 9:10 ` Petr Vorel
2020-09-29 13:02 ` Cyril Hrubis
2020-09-29 8:38 ` Cyril Hrubis
2020-09-29 8:48 ` Petr Vorel
2020-09-29 8:51 ` Cyril Hrubis
2020-09-29 9:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5F730501.7050505@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox