From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported
Date: Tue, 29 Sep 2020 10:48:09 +0200 [thread overview]
Message-ID: <20200929084809.GB7482@dell5510> (raw)
In-Reply-To: <20200929083846.GA2717@yuki.lan>
Hi Cyril,
> Hi!
> > to fix test on kernel built without CONFIG_AIO=y.
> > Cleanup: use return instead of else, join string.
> This is both obviously ok, but the cleanup should be in a separate
> patch.
+1, I'll do.
I suggested to use tst_syscall(), but we probably want here to use libc wrapper
I guess, thus I'll merge this (split into 2 commits).
> You can add my reviewed-by if you split the patch into two.
> Also is this the only io_* test that fails?
> Looking at the testcases we have the io_setup01 that looks like it will
> fail with TBROK if io_setup() returns -ENOSYS.
Thanks, I'll send a separate patch for this.
Kind regards,
Petr
next prev parent reply other threads:[~2020-09-29 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 7:35 [LTP] [PATCH 1/1] io_destroy01: TCONF when unsupported Petr Vorel
2020-09-29 7:41 ` Yang Xu
2020-09-29 8:41 ` Petr Vorel
2020-09-29 9:57 ` Yang Xu
2020-09-29 11:47 ` Richard Palethorpe
2020-09-30 9:10 ` Petr Vorel
2020-09-29 13:02 ` Cyril Hrubis
2020-09-29 8:38 ` Cyril Hrubis
2020-09-29 8:48 ` Petr Vorel [this message]
2020-09-29 8:51 ` Cyril Hrubis
2020-09-29 9:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929084809.GB7482@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox