public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH v5 00/10] Introduce SAFE_FANOTIFY_MARK() macro + cleanup
@ 2020-12-01 17:42 Petr Vorel
  2020-12-01 17:42 ` [LTP] [PATCH v5 01/10] fanotify12: Drop incorrect hint Petr Vorel
                   ` (11 more replies)
  0 siblings, 12 replies; 30+ messages in thread
From: Petr Vorel @ 2020-12-01 17:42 UTC (permalink / raw)
  To: ltp

Hi Amir,

Changes v4->v5:
* Fix issue with "fanotify: Add helper for FAN_REPORT_FID support on fs"
  on fanotify01 (unwanted skipping tests). FAN_REPORT_FID is now tested
  both for general support in kernel with fanotify_init() and support on
  tested filesystem in fanotify_mark().

* Fix issue with FAN_MARK_FILESYSTEM (new commit "fanotify: Add helper
  for mark support check").

* Split "[v4,2/6] fanotify: Handle supported features checks in setup()"
  into two commits:
  fanotify: Add helper for access permission check
  fanotify: Add helper for event support check
  (easier to review).

* Drop commit "[v4,5/6] fanotify: Check FAN_REPORT_{FID, NAME} support"
  => IMHO not needed now, as there are {REQUIRE_,}FANOTIFY_FAN_REPORT_FID_ERR_MSG()
  helpers which check for FAN_REPORT_FID. Or am I'm wrong and you need it
  for your patchset?
  There will be needed to add also helper for FAN_REPORT_NAME/FAN_REPORT_DIR_FID
  for fanotify10.c (for kernels > 5.1 && < 5.9), but this is now covered by check
  in create_fanotify_groups() and I don't want to block your patchset even more.
  And this helper should eliminate a need for check in safe_fanotify_init().

* Also safe_fanotify_mark() got simplified more (removing check for
  FAN_MARK_FILESYSTEM and EOPNOTSUPP etc.).

* Properly remove TCONF messages in commit where they're replaced
  (fanotify10.c, also for FAN_REPORT_FID in fanotify01.c and
  fanotify15.c due FAN_REPORT_FID handled in
  {REQUIRE_,}FANOTIFY_FAN_REPORT_FID_ERR_MSG()).

* New commits:
  fanotify: Add helper for mark support check
  fanotify: Use tst_brk_ in safe_fanotify_init()
  fanotify16: Test also on FUSE
  fanotify: Cleanup <sys/fanotify.h> use

I tested everything on kernel without FAN_MARK_FILESYSTEM and
FAN_REPORT_FID support and on newer kernels (5.3.18, 5.7.1, 5.10.0-rc5).

Hope I haven't omitted anything this time (apart from helper for
FAN_REPORT_NAME/FAN_REPORT_DIR_FID).

Kind regards,
Petr

Petr Vorel (10):
  fanotify12: Drop incorrect hint
  fanotify: Add helper for access permission check
  fanotify: Add helper for event support check
  fanotify: Add helper for FAN_REPORT_FID support on fs
  fanotify16: Test also on FUSE
  fanotify: Add helper for mark support check
  fanotify: Introduce SAFE_FANOTIFY_MARK() macro
  fanotify: Use tst_brk_ in safe_fanotify_init()
  fanotify: Add a pedantic check for return value
  fanotify: Cleanup <sys/fanotify.h> use

 testcases/kernel/syscalls/fanotify/fanotify.h | 191 +++++++++++++++---
 .../kernel/syscalls/fanotify/fanotify01.c     |  82 +++-----
 .../kernel/syscalls/fanotify/fanotify02.c     |  27 +--
 .../kernel/syscalls/fanotify/fanotify03.c     |  66 ++----
 .../kernel/syscalls/fanotify/fanotify04.c     |  37 +---
 .../kernel/syscalls/fanotify/fanotify05.c     |  14 +-
 .../kernel/syscalls/fanotify/fanotify06.c     |  26 +--
 .../kernel/syscalls/fanotify/fanotify07.c     |  22 +-
 .../kernel/syscalls/fanotify/fanotify08.c     |   5 +-
 .../kernel/syscalls/fanotify/fanotify09.c     |  24 +--
 .../kernel/syscalls/fanotify/fanotify10.c     |  56 ++---
 .../kernel/syscalls/fanotify/fanotify11.c     |  12 +-
 .../kernel/syscalls/fanotify/fanotify12.c     |  63 ++----
 .../kernel/syscalls/fanotify/fanotify13.c     |  59 ++----
 .../kernel/syscalls/fanotify/fanotify14.c     |   6 +-
 .../kernel/syscalls/fanotify/fanotify15.c     |  47 +----
 .../kernel/syscalls/fanotify/fanotify16.c     |  32 +--
 17 files changed, 320 insertions(+), 449 deletions(-)

-- 
2.29.2


^ permalink raw reply	[flat|nested] 30+ messages in thread
end of thread, other threads:[~2020-12-04 13:47 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-01 17:42 [LTP] [PATCH v5 00/10] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-12-01 17:42 ` [LTP] [PATCH v5 01/10] fanotify12: Drop incorrect hint Petr Vorel
2020-12-02 15:09   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 02/10] fanotify: Add helper for access permission check Petr Vorel
2020-12-02 15:24   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 03/10] fanotify: Add helper for event support check Petr Vorel
2020-12-02 15:36   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 04/10] fanotify: Add helper for FAN_REPORT_FID support on fs Petr Vorel
2020-12-02 15:46   ` Cyril Hrubis
2020-12-02 18:04     ` Petr Vorel
2020-12-04 10:11       ` Amir Goldstein
2020-12-04 13:47         ` Petr Vorel
2020-12-01 17:42 ` [LTP] [PATCH v5 05/10] fanotify16: Test also on FUSE Petr Vorel
2020-12-02 15:46   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 06/10] fanotify: Add helper for mark support check Petr Vorel
2020-12-02  6:27   ` Amir Goldstein
2020-12-02 15:57     ` Cyril Hrubis
2020-12-02 17:05     ` Petr Vorel
2020-12-02 15:53   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 07/10] fanotify: Introduce SAFE_FANOTIFY_MARK() macro Petr Vorel
2020-12-02 15:55   ` Cyril Hrubis
2020-12-02 15:58     ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 08/10] fanotify: Use tst_brk_ in safe_fanotify_init() Petr Vorel
2020-12-02 15:55   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 09/10] fanotify: Add a pedantic check for return value Petr Vorel
2020-12-02 15:56   ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH] fanotify: Cleanup <sys/fanotify.h> use Petr Vorel
2020-12-02 16:12   ` Cyril Hrubis
2020-12-01 17:46 ` [LTP] [PATCH v5 00/10] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-12-02  6:47 ` Amir Goldstein

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox