* [LTP] [PATCH] ltp-pan: Use long long int to print time_t
@ 2020-12-21 6:14 Khem Raj
2020-12-21 21:25 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2020-12-21 6:14 UTC (permalink / raw)
To: ltp
Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit time_t so
using %ld is not sufficient to print time_t, this also fixes a crash in
ltp-pan on riscv32
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
pan/ltp-pan.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
index 8b9fbe5594..54b7cb8f26 100644
--- a/pan/ltp-pan.c
+++ b/pan/ltp-pan.c
@@ -1389,8 +1389,8 @@ static void write_test_start(struct tag_pgrp *running, int no_kmsg)
if (!strcmp(reporttype, "rts")) {
printf
- ("%s\ntag=%s stime=%ld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n",
- "<<<test_start>>>", running->cmd->name, running->mystime,
+ ("%s\ntag=%s stime=%lld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n",
+ "<<<test_start>>>", running->cmd->name, (long long)running->mystime,
running->cmd->cmdline, "", "exit", "<<<test_output>>>");
}
fflush(stdout);
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] ltp-pan: Use long long int to print time_t
2020-12-21 6:14 [LTP] [PATCH] ltp-pan: Use long long int to print time_t Khem Raj
@ 2020-12-21 21:25 ` Petr Vorel
2020-12-22 17:05 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2020-12-21 21:25 UTC (permalink / raw)
To: ltp
Hi Khem,
> Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit time_t so
> using %ld is not sufficient to print time_t, this also fixes a crash in
> ltp-pan on riscv32
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, thank you!
Kind regards,
Petr
> ---
> pan/ltp-pan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
> index 8b9fbe5594..54b7cb8f26 100644
> --- a/pan/ltp-pan.c
> +++ b/pan/ltp-pan.c
> @@ -1389,8 +1389,8 @@ static void write_test_start(struct tag_pgrp *running, int no_kmsg)
> if (!strcmp(reporttype, "rts")) {
> printf
> - ("%s\ntag=%s stime=%ld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n",
> - "<<<test_start>>>", running->cmd->name, running->mystime,
> + ("%s\ntag=%s stime=%lld\ncmdline=\"%s\"\ncontacts=\"%s\"\nanalysis=%s\n%s\n",
> + "<<<test_start>>>", running->cmd->name, (long long)running->mystime,
> running->cmd->cmdline, "", "exit", "<<<test_output>>>");
> }
> fflush(stdout);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH] ltp-pan: Use long long int to print time_t
2020-12-21 21:25 ` Petr Vorel
@ 2020-12-22 17:05 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2020-12-22 17:05 UTC (permalink / raw)
To: ltp
Hi Khem,
> > Some newer 32bit architectures ( e.g. riscv32 ) uses 64bit time_t so
> > using %ld is not sufficient to print time_t, this also fixes a crash in
> > ltp-pan on riscv32
Merged, thanks!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-22 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-21 6:14 [LTP] [PATCH] ltp-pan: Use long long int to print time_t Khem Raj
2020-12-21 21:25 ` Petr Vorel
2020-12-22 17:05 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox