Re: [LTP] [PATCH v2 1/1] lib: Multiply slow config only for a real tests

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > via:
> > tst_max_delay_ = tst_multiply_timeout(MAX_DELAY * 1000000);

> > I wonder if this should be wrapped with
> > #ifndef TST_NO_DEFAULT_MAIN

> I do not think so, it makes perfect sense that the timeout for retry is
> multiplied on a debug kernel. The real question is if we need to retry
> the clone in the case of tst_ns_exec. The commit that added the retry
> loop was:

> commit 7d882081a5613f44a12fc6b1c44267d4df0857a4
> Author: Petr Vorel <pvorel@suse.cz>
> Date:   Mon Mar 28 22:46:43 2022 +0200

>     lib: Retry safe_clone() on ENOSPC

>     In some tests we are creating the namespaces faster than they are being
>     asynchronously cleaned up in the kernel:


> I guess that this is not going to be the case for tst_ns_exec because we
> are not adding new namespaces but rather cloning a processes into an
> existing namespace.

I guess you're right. Also the fix was for userns08.c. For now it would be ok
for me to change SAFE_CLONE() => tst_clone(). Or do you want properly fix
safe_clone()?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp