From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] lib: Multiply slow config only for a real tests
Date: Fri, 17 Jan 2025 11:31:49 +0100 [thread overview]
Message-ID: <Z4oxlVP5VCVpO0mc@yuki.lan> (raw)
In-Reply-To: <20250117102825.GA750951@pevik>
Hi!
> > diff --git a/testcases/lib/tst_ns_exec.c b/testcases/lib/tst_ns_exec.c
> > index 6a8e39339..989bb8910 100644
> > --- a/testcases/lib/tst_ns_exec.c
> > +++ b/testcases/lib/tst_ns_exec.c
> > @@ -100,7 +100,12 @@ int main(int argc, char *argv[])
> > for (i = 0; i < ns_fds; i++)
> > SAFE_SETNS(ns_fd[i], 0);
>
> > - pid = SAFE_CLONE(&args);
> > + pid = tst_clone(&args);
> > + if (pid < 0) {
> > + printf("clone() failed");
> > + return 1;
> > + }
> > +
> > if (!pid)
> > SAFE_EXECVP(argv[3], argv+3);
>
> Thanks, it works! Could you please merge it? Maybe update the comment?
>
> - .forks_child = 1, /* Needed by SAFE_CLONE */
> + .forks_child = 1, /* Needed by safe_clone() */
I guess that we do not need that one anymore. Does the helper work if
we remove it?
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Fixes: 893ca0abe7 ("lib: multiply the timeout if detect slow kconfigs")
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-17 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 8:41 [LTP] [PATCH v2 1/1] lib: Multiply slow config only for a real tests Petr Vorel
2025-01-17 8:55 ` Li Wang
2025-01-17 9:16 ` Petr Vorel
2025-01-17 9:26 ` Li Wang
2025-01-17 9:34 ` Li Wang
2025-01-17 9:40 ` Cyril Hrubis
2025-01-17 9:57 ` Petr Vorel
2025-01-17 10:14 ` Cyril Hrubis
2025-01-17 10:28 ` Petr Vorel
2025-01-17 10:31 ` Cyril Hrubis [this message]
2025-01-17 10:51 ` Petr Vorel
2025-01-17 10:55 ` Petr Vorel
2025-01-17 10:18 ` Petr Vorel
2025-01-17 10:30 ` Cyril Hrubis
2025-01-17 11:47 ` Petr Vorel
2025-01-17 12:07 ` Cyril Hrubis
2025-01-17 12:21 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4oxlVP5VCVpO0mc@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox