Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/1] lib: Multiply slow config only for a real tests
Date: Fri, 17 Jan 2025 11:30:44 +0100	[thread overview]
Message-ID: <Z4oxVM7f9jppXtpZ@yuki.lan> (raw)
In-Reply-To: <20250117101804.GA750287@pevik>

Hi!
> via:
> tst_max_delay_ = tst_multiply_timeout(MAX_DELAY * 1000000);
> 
> I wonder if this should be wrapped with
> #ifndef TST_NO_DEFAULT_MAIN

I do not think so, it makes perfect sense that the timeout for retry is
multiplied on a debug kernel. The real question is if we need to retry
the clone in the case of tst_ns_exec. The commit that added the retry
loop was:

commit 7d882081a5613f44a12fc6b1c44267d4df0857a4
Author: Petr Vorel <pvorel@suse.cz>
Date:   Mon Mar 28 22:46:43 2022 +0200

    lib: Retry safe_clone() on ENOSPC

    In some tests we are creating the namespaces faster than they are being
    asynchronously cleaned up in the kernel:


I guess that this is not going to be the case for tst_ns_exec because we
are not adding new namespaces but rather cloning a processes into an
existing namespace.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-01-17 10:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17  8:41 [LTP] [PATCH v2 1/1] lib: Multiply slow config only for a real tests Petr Vorel
2025-01-17  8:55 ` Li Wang
2025-01-17  9:16   ` Petr Vorel
2025-01-17  9:26     ` Li Wang
2025-01-17  9:34       ` Li Wang
2025-01-17  9:40 ` Cyril Hrubis
2025-01-17  9:57   ` Petr Vorel
2025-01-17 10:14     ` Cyril Hrubis
2025-01-17 10:28       ` Petr Vorel
2025-01-17 10:31         ` Cyril Hrubis
2025-01-17 10:51           ` Petr Vorel
2025-01-17 10:55           ` Petr Vorel
2025-01-17 10:18     ` Petr Vorel
2025-01-17 10:30       ` Cyril Hrubis [this message]
2025-01-17 11:47         ` Petr Vorel
2025-01-17 12:07           ` Cyril Hrubis
2025-01-17 12:21             ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4oxVM7f9jppXtpZ@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox