Re: [LTP] [PATCH v2] include/lapi: add leaf Makefile

Re: [LTP] [PATCH v2] include/lapi: add leaf Makefile

[Li Wang]

Hi Petr, Jinseok,

Petr Vorel wrote:

> > Convert include/Makefile to use generic_trunk_target.mk and
> > add minimal leaf Makefile in include/lapi.
> 
> add minimal leaf Makefile in include/lapi in order to have 'make check'.
> 
> FYI AI is correct it's better to describe the reason (although we have a ticket,
> one day might github disappear and we lost the reason in the ticket).
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Wait little longer if Li has time to ack this.

The v2 generally looks good (with Petr's suggestion).
Feel free to merge/refine with:

Reviewed-by: Li Wang <wangli.ahau@gmail.com>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2] include/lapi: add leaf Makefile

[Petr Vorel]

> Hi Petr, Jinseok,

> Petr Vorel wrote:

> > > Convert include/Makefile to use generic_trunk_target.mk and
> > > add minimal leaf Makefile in include/lapi.

> > add minimal leaf Makefile in include/lapi in order to have 'make check'.

> > FYI AI is correct it's better to describe the reason (although we have a ticket,
> > one day might github disappear and we lost the reason in the ticket).

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Wait little longer if Li has time to ack this.

> The v2 generally looks good (with Petr's suggestion).
> Feel free to merge/refine with:

> Reviewed-by: Li Wang <wangli.ahau@gmail.com>

Good, merged (I wanted to change the subject to have 'make check' but in the end
I kept the original. I dared to add my Suggested-by:.

And you're Cced with follow-up cleanup in include/Makefile.

Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] include/lapi: add leaf Makefile

[Petr Vorel]

> Petr Vorel <pvorel@suse.cz> wrote:

> > > > +INSTALL_DIR            := $(includedir)/lapi

> > > I'm doubting should we install the include/lapi/ local header files to
> > > the /opt/ltp/include?

> > Do you question *whether* install lapi/*.h or *where* to install them?
> > We install include/*.h files. What is a difference with include/lapi/?

> The former, I guess we don't need to install any.

+1

> > I'd say either install both or none. I would prefer to not install any,
> > LTP library is not separated anyway (there is an old Andrea's effort, but that
> > uses meson anyway). Installation was added in 2008 and I doubt anybody is using
> > it.

> Yes, that was exactly my point, we'd better remove the INSTALL_* part
> from the Makefile you posted.

> -INSTALL_DIR            := $(includedir)/lapi
> -
> -INSTALL_MODE           := 00644
> -
> -INSTALL_TARGETS                := *.h

+1, let's drop it. Ideally as a separate patch in include/Makefile, so that
include/lapi/Makefile can be based on it. Maybe we could even have a template in
include/mk/ instead of copypasting (when now we will not have INSTALL_*, but I
don't require it (it's just 2x Makefile, they can be copy pasted).


> > > > --- include/lapi/syscalls/Makefile
> > > > +++ /dev/null

> > > Does the `make check` still work (inside include/lapi/syscalls/)
> > > without this Makefile?

> > Sure not. Do we really want to check generate_arch.sh and generate_syscalls.sh
> > in arch? If yes, sure it needs to be added, but that was not my intention when
> > creating #1262. I really wanted to check C (and shell) library and tests code.

> I'm ok with both, so without that Makefile we could do `make check` in
> /include/lapi/.

+1.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2] include/lapi: add leaf Makefile

[Jinseok Kim]

Convert include/Makefile to use generic_trunk_target.mk and
add minimal leaf Makefile in include/lapi.

Fixes: https://github.com/linux-test-project/ltp/issues/1262

Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
---
Changes in v2:
- Switch include/Makefile to trunk and remove lapi/syscalls/Makefile
- Link to v1 : https://lore.kernel.org/ltp/20260410175031.16921-1-always.starving0@gmail.com
---
 include/Makefile      |  2 +-
 include/lapi/Makefile | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 include/lapi/Makefile

diff --git a/include/Makefile b/include/Makefile
index 6b31b046e..84cd4ed6e 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean

 vpath %.h $(abs_srcdir)

-include $(top_srcdir)/include/mk/generic_leaf_target.mk
+include $(top_srcdir)/include/mk/generic_trunk_target.mk
diff --git a/include/lapi/Makefile b/include/lapi/Makefile
new file mode 100644
index 000000000..f265f856d
--- /dev/null
+++ b/include/lapi/Makefile
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (C) 2009, Cisco Systems Inc.
+# Copyright (c) Linux Test Project, 2026
+# Ngie Cooper, July 2009
+
+top_srcdir              ?= ../../
+
+include $(top_srcdir)/include/mk/env_pre.mk
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
--
2.43.0

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2] include/lapi: add leaf Makefile

[Petr Vorel]

Hi Jinseok,

> Convert include/Makefile to use generic_trunk_target.mk and
> add minimal leaf Makefile in include/lapi.

add minimal leaf Makefile in include/lapi in order to have 'make check'.

FYI AI is correct it's better to describe the reason (although we have a ticket,
one day might github disappear and we lost the reason in the ticket).

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Wait little longer if Li has time to ack this.

> Fixes: https://github.com/linux-test-project/ltp/issues/1262

> Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
> ---
> Changes in v2:
> - Switch include/Makefile to trunk and remove lapi/syscalls/Makefile
> - Link to v1 : https://lore.kernel.org/ltp/20260410175031.16921-1-always.starving0@gmail.com
> ---
>  include/Makefile      |  2 +-
>  include/lapi/Makefile | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
>  create mode 100644 include/lapi/Makefile

> diff --git a/include/Makefile b/include/Makefile
> index 6b31b046e..84cd4ed6e 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean

>  vpath %.h $(abs_srcdir)

> -include $(top_srcdir)/include/mk/generic_leaf_target.mk
> +include $(top_srcdir)/include/mk/generic_trunk_target.mk
> diff --git a/include/lapi/Makefile b/include/lapi/Makefile
> new file mode 100644
> index 000000000..f265f856d
> --- /dev/null
> +++ b/include/lapi/Makefile
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2009, Cisco Systems Inc.
I'll remove this line before merge. IMHO it's no longer Cisco work :).
While this is related when code is significantly based on old code,
I would not bother with 2 lines of Makefile.

> +# Copyright (c) Linux Test Project, 2026
> +# Ngie Cooper, July 2009
And this one.

Kind regards,
Petr

> +
> +top_srcdir              ?= ../../
> +
> +include $(top_srcdir)/include/mk/env_pre.mk
> +
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp