Re: [LTP] [PATCH v2] include/lapi: add leaf Makefile

[Petr Vorel <pvorel@suse.cz>]

Hi Jinseok,

> Convert include/Makefile to use generic_trunk_target.mk and
> add minimal leaf Makefile in include/lapi.

add minimal leaf Makefile in include/lapi in order to have 'make check'.

FYI AI is correct it's better to describe the reason (although we have a ticket,
one day might github disappear and we lost the reason in the ticket).

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Wait little longer if Li has time to ack this.

> Fixes: https://github.com/linux-test-project/ltp/issues/1262

> Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
> ---
> Changes in v2:
> - Switch include/Makefile to trunk and remove lapi/syscalls/Makefile
> - Link to v1 : https://lore.kernel.org/ltp/20260410175031.16921-1-always.starving0@gmail.com
> ---
>  include/Makefile      |  2 +-
>  include/lapi/Makefile | 10 ++++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
>  create mode 100644 include/lapi/Makefile

> diff --git a/include/Makefile b/include/Makefile
> index 6b31b046e..84cd4ed6e 100644
> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean

>  vpath %.h $(abs_srcdir)

> -include $(top_srcdir)/include/mk/generic_leaf_target.mk
> +include $(top_srcdir)/include/mk/generic_trunk_target.mk
> diff --git a/include/lapi/Makefile b/include/lapi/Makefile
> new file mode 100644
> index 000000000..f265f856d
> --- /dev/null
> +++ b/include/lapi/Makefile
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2009, Cisco Systems Inc.
I'll remove this line before merge. IMHO it's no longer Cisco work :).
While this is related when code is significantly based on old code,
I would not bother with 2 lines of Makefile.

> +# Copyright (c) Linux Test Project, 2026
> +# Ngie Cooper, July 2009
And this one.

Kind regards,
Petr

> +
> +top_srcdir              ?= ../../
> +
> +include $(top_srcdir)/include/mk/env_pre.mk
> +
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp