Re: [LTP] [PATCH] include/lapi: add leaf Makefile

[Petr Vorel <pvorel@suse.cz>]

Hi Jinseok,

Thanks for fixing this!

> Fixes : https://github.com/linux-test-project/ltp/issues/1262

nit: Please next time avoid space before ':'.

Fixes: https://github.com/linux-test-project/ltp/issues/1262

> include/lapi and include/lapi/syscalls lack Makefiles, so 'make check'
> does not work in these directories. Add minimal leaf Makefiles.

nit: Also it'd go here.

> Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
> ---
>  include/lapi/Makefile          | 8 ++++++++
>  include/lapi/syscalls/Makefile | 8 ++++++++
>  2 files changed, 16 insertions(+)
>  create mode 100644 include/lapi/Makefile
>  create mode 100644 include/lapi/syscalls/Makefile

> diff --git a/include/lapi/Makefile b/include/lapi/Makefile
> new file mode 100644
> index 000000000..83ef85c77
> --- /dev/null
> +++ b/include/lapi/Makefile
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2026 Jinseok Kim <always.starving0@gmail.com>
> +
> +top_srcdir              ?= ../../
> +
> +include $(top_srcdir)/include/mk/env_pre.mk
> +
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> diff --git a/include/lapi/syscalls/Makefile b/include/lapi/syscalls/Makefile

> new file mode 100644
> index 000000000..e46c90ef5
> --- /dev/null
> +++ b/include/lapi/syscalls/Makefile
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2026 Jinseok Kim <always.starving0@gmail.com>
> +
> +top_srcdir              ?= ../../../
> +
> +include $(top_srcdir)/include/mk/env_pre.mk
> +
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk

Why do we need this file? This one should be deleted. Also, because make install
works for include directory, it should work here as well.
I would just copy that header, update top_srcdir location and also include
generic_trunk_target.mk to include/Makefile.

I think this is a better version.

Kind regards,
Petr

diff --git include/Makefile include/Makefile
index 6b31b046e4..84cd4ed6e3 100644
--- include/Makefile
+++ include/Makefile
@@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean
 
 vpath %.h $(abs_srcdir)
 
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
+include $(top_srcdir)/include/mk/generic_trunk_target.mk
diff --git include/lapi/Makefile include/lapi/Makefile
index 83ef85c77c..2a66e5aff6 100644
--- include/lapi/Makefile
+++ include/lapi/Makefile
@@ -1,8 +1,28 @@
 # SPDX-License-Identifier: GPL-2.0-or-later
-# Copyright (C) 2026 Jinseok Kim <always.starving0@gmail.com>
+# Copyright (C) 2009, Cisco Systems Inc.
+# Copyright (c) Linux Test Project, 2026
+# Ngie Cooper, July 2009
 
-top_srcdir              ?= ../../
+top_srcdir		?= ../..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 
+INSTALL_DIR		:= $(includedir)/lapi
+
+INSTALL_MODE		:= 00644
+
+INSTALL_TARGETS		:= *.h
+
+MAKE_TARGETS		:=
+
+.PHONY: ac-clean ac-distclean ac-maintainer-clean distclean maintainer-clean
+distclean:: clean ac-distclean
+maintainer-clean:: distclean ac-maintainer-clean
+ac-clean ac-distclean::
+	$(RM) -f config.h lapi/syscalls.h stamp-h1
+ac-maintainer-clean:: ac-clean
+	$(RM) -f config.h.in
+
+vpath %.h $(abs_srcdir)
+
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git include/lapi/syscalls/Makefile include/lapi/syscalls/Makefile
deleted file mode 100644
index e46c90ef5f..0000000000
--- include/lapi/syscalls/Makefile
+++ /dev/null
@@ -1,8 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
-# Copyright (C) 2026 Jinseok Kim <always.starving0@gmail.com>
-
-top_srcdir              ?= ../../../
-
-include $(top_srcdir)/include/mk/env_pre.mk
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp