public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <wangli.ahau@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] include/lapi: add leaf Makefile
Date: Fri, 17 Apr 2026 13:41:24 +0200	[thread overview]
Message-ID: <20260417114124.GB409289@pevik> (raw)
In-Reply-To: <CANgNiRzSi2OgV-vu0amVvqNW_jUK_bBpjntubERaEd-5dqUVXg@mail.gmail.com>

Hi Li,

> > Yes, that was exactly my point, we'd better remove the INSTALL_* part
> > from the Makefile you posted.

> > -INSTALL_DIR            := $(includedir)/lapi
> > -
> > -INSTALL_MODE           := 00644
> > -
> > -INSTALL_TARGETS                := *.h

> And we even don't need the additional clean targets, for the make-check
> which just simply:

> --- a/include/Makefile
> +++ b/include/Makefile
> @@ -24,4 +24,4 @@ ac-maintainer-clean:: ac-clean

>  vpath %.h $(abs_srcdir)

> -include $(top_srcdir)/include/mk/generic_leaf_target.mk
> +include $(top_srcdir)/include/mk/generic_trunk_target.mk
> diff --git a/include/lapi/Makefile b/include/lapi/Makefile
> new file mode 100644
> index 0000000..83ef85c
> --- /dev/null
> +++ b/include/lapi/Makefile
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (C) 2026 Jinseok Kim <always.starving0@gmail.com>
> +
> +top_srcdir              ?= ../../
> +
> +include $(top_srcdir)/include/mk/env_pre.mk
> +
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk

+1 (+ deleted that INSTALL_* variables).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-04-17 11:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 17:50 [LTP] [PATCH] include/lapi: add leaf Makefile Jinseok Kim
2026-04-13  9:04 ` Li Wang
2026-04-13 21:20 ` Petr Vorel
2026-04-14  7:55   ` Li Wang
2026-04-16 14:46     ` Jinseok Kim
2026-04-16 18:11       ` Petr Vorel
2026-04-16 18:05     ` Petr Vorel
2026-04-16 23:24       ` Li Wang
2026-04-17  0:11         ` Li Wang
2026-04-17 11:41           ` Petr Vorel [this message]
2026-04-17 11:34         ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260417114124.GB409289@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=wangli.ahau@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox