public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Jinseok Kim <always.starving0@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] include/lapi: add leaf Makefile
Date: Tue, 21 Apr 2026 17:05:26 +0000	[thread overview]
Message-ID: <20260421170526.3848-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260421160828.4483-1-always.starving0@gmail.com>

Hi Jinseok,

On Wed, 22 Apr 2026, Jinseok Kim wrote:
> include/lapi: add leaf Makefile
>
> Convert include/Makefile to use generic_trunk_target.mk and
> add minimal leaf Makefile in include/lapi.

The commit body describes what the patch does but not why. Please add a
sentence stating the problem, e.g.: "include/lapi/ had no Makefile of
its own, so include/ was incorrectly treated as a leaf node and headers
under lapi/ were not installed."

[...]

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24735550612

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-04-21 17:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 17:50 [LTP] [PATCH] include/lapi: add leaf Makefile Jinseok Kim
2026-04-13  9:04 ` Li Wang
2026-04-13 21:20 ` Petr Vorel
2026-04-14  7:55   ` Li Wang
2026-04-16 14:46     ` Jinseok Kim
2026-04-16 18:11       ` Petr Vorel
2026-04-16 18:05     ` Petr Vorel
2026-04-16 23:24       ` Li Wang
2026-04-17  0:11         ` Li Wang
2026-04-17 11:41           ` Petr Vorel
2026-04-17 11:34         ` Petr Vorel
2026-04-21 16:08           ` [LTP] [PATCH v2] " Jinseok Kim
2026-04-21 17:05             ` linuxtestproject.agent [this message]
2026-04-22  5:18             ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260421170526.3848-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=always.starving0@gmail.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox