Re: [LTP] read_all: Fix buffer too small for long paths

Re: [LTP] read_all: Fix buffer too small for long paths

[linuxtestproject.agent]

Hi Michael,

On Sun, 06 Sep 2026 16:56:50 +0300, Michael Menasherov wrote:
> read_all: Fix buffer too small for long paths

> -#define BUFFER_SIZE 1024
> +#define BUFFER_SIZE 4096

queue_pop() still aborts for a 4095-byte pathname: after copying its final
byte, ++j is 4095, which satisfies BUFFER_SIZE - 1. Use PATH_MAX for popped
and compare j against PATH_MAX so every pathname that fits dent_path also
fits the queue buffer.

Verdict - Needs revision

Pre-existing issue:

read_all.c:218 has an unnecessary blank line before a closing brace, as
reported by make check.

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] read_all: Fix buffer too small for long paths

[linuxtestproject.agent]

Hi Michael,

On Sep 7, 2026, Michael Menasherov wrote:
> read_all: Fix buffer too small for long paths

> +#define BUFFER_SIZE PATH_MAX

With the existing `if (++j >= BUFFER_SIZE - 1)` check, this still rejects a
valid PATH_MAX - 1-character pathname and reports TBROK before writing its
terminating NUL. A 4095-byte pathname reproduces this on PATH_MAX=4096; change
the queue_pop() bound so PATH_MAX - 1 characters fit.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v3] read_all: Fix buffer too small for long paths

[Michael Menasherov via ltp]

queue_pop() copies each path into popped[BUFFER_SIZE], but BUFFER_SIZE
was 1024 while visit_dir() builds paths up to PATH_MAX. Any path longer
than 1023 bytes aborted the test with TBROK.

Use PATH_MAX for BUFFER_SIZE and MAX_PATH, and drop the extra -1 from
the queue_pop() bound so a PATH_MAX - 1 character path fits.

Tested on smaller boards and then on local machines with deeply nested
directories under /sys.

Fixes: 67c95fbbfc3a ("Add read_all file systems test")
Signed-off-by: Michael Menasherov <mmenashe@redhat.com>
---
 testcases/kernel/fs/read_all/read_all.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/fs/read_all/read_all.c b/testcases/kernel/fs/read_all/read_all.c
index 5720ffb99..ec9454fc9 100644
--- a/testcases/kernel/fs/read_all/read_all.c
+++ b/testcases/kernel/fs/read_all/read_all.c
@@ -51,8 +51,8 @@
 #include "tst_timer.h"
 
 #define QUEUE_SIZE 16384
-#define BUFFER_SIZE 1024
-#define MAX_PATH 4096
+#define BUFFER_SIZE PATH_MAX
+#define MAX_PATH PATH_MAX
 #define MAX_DISPLAY 40
 
 struct queue {
@@ -131,7 +131,7 @@ static int queue_pop(struct queue *q)
 	while (q->data[i]) {
 		q->popped[j] = q->data[i];
 
-		if (++j >= BUFFER_SIZE - 1)
+		if (++j >= BUFFER_SIZE)
 			tst_brk(TBROK, "Buffer is too small for path");
 
 		 i = (i + 1) % QUEUE_SIZE;
-- 
2.55.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] read_all: Fix buffer too small for long paths

[linuxtestproject.agent]

Hi Michael,

On Tue Sep 8 12:22:48 2026 +0300, Michael Menasherov via ltp wrote:
> read_all: Fix buffer too small for long paths

Verdict - Reviewed

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] read_all: Fix buffer too small for long paths

[Andrea Cervesato via ltp]

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp