* [LTP] [PATCH] openposix: lib: Use the configured compiler
@ 2026-09-28 21:27 Anders Roxell
2026-09-28 23:47 ` [LTP] " linuxtestproject.agent
2026-09-29 15:07 ` [LTP] [PATCH] " Petr Vorel
0 siblings, 2 replies; 3+ messages in thread
From: Anders Roxell @ 2026-09-28 21:27 UTC (permalink / raw)
To: ltp
The lib Makefile does not include env.mk, so it does not get CC from
config.mk. When we cross compile, libcommon.a gets built with the host
compiler. Then the linker skips it and most tests fail to build.
Include env.mk, like the other Makefiles do.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
testcases/open_posix_testsuite/lib/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/testcases/open_posix_testsuite/lib/Makefile b/testcases/open_posix_testsuite/lib/Makefile
index ad6a9d7e6a1b..e63ee42647ac 100644
--- a/testcases/open_posix_testsuite/lib/Makefile
+++ b/testcases/open_posix_testsuite/lib/Makefile
@@ -1,6 +1,8 @@
top_srcdir?= ..
subdir= lib
+include $(top_srcdir)/include/mk/env.mk
+
AR?= ar
RANLIB?= ranlib
CFLAGS+= -I$(top_srcdir)/include
--
2.53.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] openposix: lib: Use the configured compiler
2026-09-28 21:27 [LTP] [PATCH] openposix: lib: Use the configured compiler Anders Roxell
@ 2026-09-28 23:47 ` linuxtestproject.agent
2026-09-29 15:07 ` [LTP] [PATCH] " Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: linuxtestproject.agent @ 2026-09-28 23:47 UTC (permalink / raw)
To: Anders Roxell; +Cc: ltp
Hi Anders,
On Mon, 28 Sep 2026 23:27:21 +0200, Anders Roxell wrote:
> openposix: lib: Use the configured compiler
Verdict - Reviewed
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] openposix: lib: Use the configured compiler
2026-09-28 21:27 [LTP] [PATCH] openposix: lib: Use the configured compiler Anders Roxell
2026-09-28 23:47 ` [LTP] " linuxtestproject.agent
@ 2026-09-29 15:07 ` Petr Vorel
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2026-09-29 15:07 UTC (permalink / raw)
To: Anders Roxell; +Cc: ltp
Hi Anders,
> The lib Makefile does not include env.mk, so it does not get CC from
> config.mk. When we cross compile, libcommon.a gets built with the host
> compiler. Then the linker skips it and most tests fail to build.
> Include env.mk, like the other Makefiles do.
Make sense, thanks!
Verified and merged even close before the release.
Kind regards,
Petr
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> testcases/open_posix_testsuite/lib/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/testcases/open_posix_testsuite/lib/Makefile b/testcases/open_posix_testsuite/lib/Makefile
> index ad6a9d7e6a1b..e63ee42647ac 100644
> --- a/testcases/open_posix_testsuite/lib/Makefile
> +++ b/testcases/open_posix_testsuite/lib/Makefile
> @@ -1,6 +1,8 @@
> top_srcdir?= ..
> subdir= lib
> +include $(top_srcdir)/include/mk/env.mk
> +
> AR?= ar
> RANLIB?= ranlib
> CFLAGS+= -I$(top_srcdir)/include
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-29 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 21:27 [LTP] [PATCH] openposix: lib: Use the configured compiler Anders Roxell
2026-09-28 23:47 ` [LTP] " linuxtestproject.agent
2026-09-29 15:07 ` [LTP] [PATCH] " Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox