* [LTP] [RFC] Patch getcpu01 testcase
@ 2009-05-28 17:02 Suzuki Poulose
2009-05-29 12:55 ` Subrata Modak
0 siblings, 1 reply; 4+ messages in thread
From: Suzuki Poulose @ 2009-05-28 17:02 UTC (permalink / raw)
To: ltp-list, Subrata Modak, sharyath
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
Hi,
The getcpu01 always exits with a non-zero exit code (indicating a
Failure as per UNIX semantics) on non-NUMA machines.
This is due to the following code :
tst_resm(TWARN,
"/sys not mounted or not a numa system. Assuming one
node: %s",
strerror(errno));
Being a non-NUMA machine is not a failure, but an info. So it should not
cause the test to have a non zero exit status.
I have attached a patch which could do the same and provide a more
friendly o/p.
Please apply.
Thanks
Suzuki
[-- Attachment #2: fix-warning-getcpu01.diff --]
[-- Type: text/plain, Size: 1106 bytes --]
Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c
===================================================================
--- ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c 2008-10-23 02:23:19.000000000 -0500
+++ ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c 2009-05-28 11:52:54.000000000 -0500
@@ -47,6 +47,8 @@
* HISTORY
* 06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com>
*
+ * 05/2009 Suzuki K P <suzuki@in.ibm.com>
+ * Friendly messages for non-NUMA machines.
* RESTRICTIONS
* none
*/
@@ -234,8 +236,10 @@
directory_parent = opendir("/sys/devices/system/node");
if (!directory_parent) {
- tst_resm(TWARN,
- "/sys not mounted or not a numa system. Assuming one node: %s",
+ tst_resm(TINFO,
+ "/sys not mounted or not a numa system. Assuming one node");
+ tst_resm(TINFO,
+ "Reason /sys/devices/system/node :%s",
strerror(errno));
return 0; //By Default assume it to belong to node Zero
} else {
[-- Attachment #3: Type: text/plain, Size: 444 bytes --]
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com
[-- Attachment #4: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [RFC] Patch getcpu01 testcase 2009-05-28 17:02 [LTP] [RFC] Patch getcpu01 testcase Suzuki Poulose @ 2009-05-29 12:55 ` Subrata Modak 2009-05-29 13:34 ` Suzuki Poulose 0 siblings, 1 reply; 4+ messages in thread From: Subrata Modak @ 2009-05-29 12:55 UTC (permalink / raw) To: Suzuki Poulose; +Cc: ltp-list, sharyath On Thu, 2009-05-28 at 22:32 +0530, Suzuki Poulose wrote: > Hi, > > The getcpu01 always exits with a non-zero exit code (indicating a > Failure as per UNIX semantics) on non-NUMA machines. > > This is due to the following code : > > tst_resm(TWARN, > "/sys not mounted or not a numa system. Assuming > one > node: %s", > strerror(errno)); > > > Being a non-NUMA machine is not a failure, but an info. So it should > not > cause the test to have a non zero exit status. Correct, > > I have attached a patch which could do the same and provide a more > friendly o/p. > > > Please apply. > > Thanks > Suzuki > > > > > > > > > > > > plain text > document > attachment > (fix-warning-getcpu01.diff) > > > Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c > =================================================================== > --- > ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c 2008-10-23 02:23:19.000000000 -0500 > +++ > ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c 2009-05-28 > 11:52:54.000000000 -0500 > @@ -47,6 +47,8 @@ > * HISTORY > * 06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com> > * > + * 05/2009 Suzuki K P <suzuki@in.ibm.com> > + * Friendly messages for non-NUMA machines. > * RESTRICTIONS > * none > */ > @@ -234,8 +236,10 @@ > > directory_parent = opendir("/sys/devices/system/node"); > if (!directory_parent) { > - tst_resm(TWARN, > - "/sys not mounted or not a numa system. Assuming > one node: %s", > + tst_resm(TINFO, > + "/sys not mounted or not a numa system. > Assuming one node"); > + tst_resm(TINFO, Use TCONF instead of TINFO. That reflects that some system configuration was missing, and, it will not return error value at all. Regards-- Subrata > + "Reason /sys/devices/system/node :%s", > strerror(errno)); > return 0; //By Default assume it to belong to > node Zero > } else { > ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [RFC] Patch getcpu01 testcase 2009-05-29 12:55 ` Subrata Modak @ 2009-05-29 13:34 ` Suzuki Poulose 2009-05-30 18:40 ` Subrata Modak 0 siblings, 1 reply; 4+ messages in thread From: Suzuki Poulose @ 2009-05-29 13:34 UTC (permalink / raw) To: subrata; +Cc: ltp-list, sharyath [-- Attachment #1: Type: text/plain, Size: 2413 bytes --] Subrata, Good ! Then thats more suitable here :) Refreshed the patch with TCONF and a better error message. Thanks Suzuki Subrata Modak wrote: > On Thu, 2009-05-28 at 22:32 +0530, Suzuki Poulose wrote: >> Hi, >> >> The getcpu01 always exits with a non-zero exit code (indicating a >> Failure as per UNIX semantics) on non-NUMA machines. >> >> This is due to the following code : >> >> tst_resm(TWARN, >> "/sys not mounted or not a numa system. Assuming >> one >> node: %s", >> strerror(errno)); >> >> >> Being a non-NUMA machine is not a failure, but an info. So it should >> not >> cause the test to have a non zero exit status. > > Correct, > >> I have attached a patch which could do the same and provide a more >> friendly o/p. >> >> >> Please apply. >> >> Thanks >> Suzuki >> >> >> >> >> >> >> >> >> >> >> >> plain text >> document >> attachment >> (fix-warning-getcpu01.diff) >> >> >> Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c >> =================================================================== >> --- >> ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c 2008-10-23 02:23:19.000000000 -0500 >> +++ >> ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c 2009-05-28 >> 11:52:54.000000000 -0500 >> @@ -47,6 +47,8 @@ >> * HISTORY >> * 06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com> >> * >> + * 05/2009 Suzuki K P <suzuki@in.ibm.com> >> + * Friendly messages for non-NUMA machines. >> * RESTRICTIONS >> * none >> */ >> @@ -234,8 +236,10 @@ >> >> directory_parent = opendir("/sys/devices/system/node"); >> if (!directory_parent) { >> - tst_resm(TWARN, >> - "/sys not mounted or not a numa system. Assuming >> one node: %s", >> + tst_resm(TINFO, >> + "/sys not mounted or not a numa system. >> Assuming one node"); >> + tst_resm(TINFO, > > Use TCONF instead of TINFO. That reflects that some system configuration > was missing, and, it will not return error value at all. > > Regards-- > Subrata > >> + "Reason /sys/devices/system/node :%s", >> strerror(errno)); >> return 0; //By Default assume it to belong to >> node Zero >> } else { >> > [-- Attachment #2: fix-warning-getcpu01.diff --] [-- Type: text/plain, Size: 1122 bytes --] Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c =================================================================== --- ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c 2008-10-23 02:23:19.000000000 -0500 +++ ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c 2009-05-29 08:33:01.000000000 -0500 @@ -47,6 +47,9 @@ * HISTORY * 06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com> * + * 05/2009 Suzuki K P <suzuki@in.ibm.com> + * Use TCONF instead of TWARN for non-NUMA machines + * * RESTRICTIONS * none */ @@ -234,8 +237,10 @@ directory_parent = opendir("/sys/devices/system/node"); if (!directory_parent) { - tst_resm(TWARN, - "/sys not mounted or not a numa system. Assuming one node: %s", + tst_resm(TCONF, + "/sys not mounted or not a numa system. Assuming one node"); + tst_resm(TCONF, + "Error opening: /sys/devices/system/node :%s", strerror(errno)); return 0; //By Default assume it to belong to node Zero } else { [-- Attachment #3: Type: text/plain, Size: 444 bytes --] ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com [-- Attachment #4: Type: text/plain, Size: 155 bytes --] _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [RFC] Patch getcpu01 testcase 2009-05-29 13:34 ` Suzuki Poulose @ 2009-05-30 18:40 ` Subrata Modak 0 siblings, 0 replies; 4+ messages in thread From: Subrata Modak @ 2009-05-30 18:40 UTC (permalink / raw) To: Suzuki Poulose; +Cc: ltp-list, sharyath On Fri, 2009-05-29 at 19:04 +0530, Suzuki Poulose wrote: > Subrata, > > Good ! Then thats more suitable here :) > > Refreshed the patch with TCONF and a better error message. Thanks. Regards-- Subrata > > Thanks > > Suzuki > Subrata Modak wrote: > > On Thu, 2009-05-28 at 22:32 +0530, Suzuki Poulose wrote: > >> Hi, > >> > >> The getcpu01 always exits with a non-zero exit code (indicating a > >> Failure as per UNIX semantics) on non-NUMA machines. > >> > >> This is due to the following code : > >> > >> tst_resm(TWARN, > >> "/sys not mounted or not a numa system. Assuming > >> one > >> node: %s", > >> strerror(errno)); > >> > >> > >> Being a non-NUMA machine is not a failure, but an info. So it should > >> not > >> cause the test to have a non zero exit status. > > > > Correct, > > > >> I have attached a patch which could do the same and provide a more > >> friendly o/p. > >> > >> > >> Please apply. > >> > >> Thanks > >> Suzuki > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> plain text > >> document > >> attachment > >> (fix-warning-getcpu01.diff) > >> > >> > >> Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c > >> =================================================================== > >> --- > >> ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c 2008-10-23 02:23:19.000000000 -0500 > >> +++ > >> ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c 2009-05-28 > >> 11:52:54.000000000 -0500 > >> @@ -47,6 +47,8 @@ > >> * HISTORY > >> * 06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com> > >> * > >> + * 05/2009 Suzuki K P <suzuki@in.ibm.com> > >> + * Friendly messages for non-NUMA machines. > >> * RESTRICTIONS > >> * none > >> */ > >> @@ -234,8 +236,10 @@ > >> > >> directory_parent = opendir("/sys/devices/system/node"); > >> if (!directory_parent) { > >> - tst_resm(TWARN, > >> - "/sys not mounted or not a numa system. Assuming > >> one node: %s", > >> + tst_resm(TINFO, > >> + "/sys not mounted or not a numa system. > >> Assuming one node"); > >> + tst_resm(TINFO, > > > > Use TCONF instead of TINFO. That reflects that some system configuration > > was missing, and, it will not return error value at all. > > > > Regards-- > > Subrata > > > >> + "Reason /sys/devices/system/node :%s", > >> strerror(errno)); > >> return 0; //By Default assume it to belong to > >> node Zero > >> } else { > >> > > > > plain text document attachment (fix-warning-getcpu01.diff) > Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c > =================================================================== > --- ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c 2008-10-23 02:23:19.000000000 -0500 > +++ ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c 2009-05-29 08:33:01.000000000 -0500 > @@ -47,6 +47,9 @@ > * HISTORY > * 06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com> > * > + * 05/2009 Suzuki K P <suzuki@in.ibm.com> > + * Use TCONF instead of TWARN for non-NUMA machines > + * > * RESTRICTIONS > * none > */ > @@ -234,8 +237,10 @@ > > directory_parent = opendir("/sys/devices/system/node"); > if (!directory_parent) { > - tst_resm(TWARN, > - "/sys not mounted or not a numa system. Assuming one node: %s", > + tst_resm(TCONF, > + "/sys not mounted or not a numa system. Assuming one node"); > + tst_resm(TCONF, > + "Error opening: /sys/devices/system/node :%s", > strerror(errno)); > return 0; //By Default assume it to belong to node Zero > } else { ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-05-30 18:41 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-05-28 17:02 [LTP] [RFC] Patch getcpu01 testcase Suzuki Poulose 2009-05-29 12:55 ` Subrata Modak 2009-05-29 13:34 ` Suzuki Poulose 2009-05-30 18:40 ` Subrata Modak
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox