Re: [LTP] [PATCH v2 5/6] shell: Add test for TST_FORMAT_DEVICE=1

["xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>]

Hi Petr
> Unfortunately GitHub Actions don't have loop devices, thus cannot be run
> in CI:
> 
> tst_format_device 1 TINFO: timeout per run is 0h 5m 0s
> /__w/ltp/ltp/lib/tst_device.c:139: TINFO: No free devices found
> 
> Signed-off-by: Petr Vorel<pvorel@suse.cz>
> ---
> Same as in v1
> 
>   lib/newlib_tests/shell/tst_format_device.sh | 24 +++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>   create mode 100755 lib/newlib_tests/shell/tst_format_device.sh
> 
> diff --git a/lib/newlib_tests/shell/tst_format_device.sh b/lib/newlib_tests/shell/tst_format_device.sh
> new file mode 100755
> index 0000000000..b02f8b122b
> --- /dev/null
> +++ b/lib/newlib_tests/shell/tst_format_device.sh
> @@ -0,0 +1,24 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (c) 2022 Petr Vorel<pvorel@suse.cz>
> +
> +TST_FORMAT_DEVICE=1
> +TST_TESTFUNC=test
> +TST_CNT=2
> +TST_DEV_FS_OPTS="-b 1024 -O quota"
> +TST_DEV_EXTRA_OPTS="5m"
> +TST_NEEDS_CMDS="df lsblk"
> +. tst_test.sh
> +
> +test1()
> +{
> +	tst_res TPASS "device formatted"
> +}
> +
> +test2()
> +{
> +	tst_check_cmds df || return
We have checked df command in TST_NEEDS_CMDS, why still check it again
in here?

Best Regards
Yang Xu
> +	EXPECT_PASS "df $TST_DEVICE | grep -q /dev"
> +}
> +
> +tst_run

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp