From: Petr Vorel <pvorel@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 6/6] doc: Add missing shell variables
Date: Fri, 11 Feb 2022 08:48:43 +0100 [thread overview]
Message-ID: <YgYU26YmOgFsr4o9@pevik> (raw)
In-Reply-To: <62060233.6010505@fujitsu.com>
Hi Xu,
> Hi Petr
> This patchset looks good to me, so
> Acked-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ps: I think we can add two basic tests for this,
> 1)test TST_FS_TYPE whether format the specified filesystem ie using ext4
BTW the default is ext2. Also not sure how to do it when formatting loop device.
Verifying filesystem I'll add when I add TST_NEEDS_MOUNT flag.
losetup prints:
/dev/loop0: [65025]:176189 (/tmp/LTP_tst_format_device.9bya3blyQD/test_dev.img)
> 2)test tst_mkfs whether format failed if not specifying TST_NEEDS_DEVICE
> and call tst_mkfs directly
+1. I'll also document here what is the purpose (we have many tests which are
expected to TFAIL/TBROK, but it's not documented in the tests thus it's hard to
run them locally.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-11 7:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 16:27 [LTP] [PATCH v2 0/6] Add TST_FORMAT_DEVICE support Petr Vorel
2022-02-10 16:27 ` [LTP] [PATCH v2 1/6] tst_test.sh: Properly init $TST_FS_TYPE Petr Vorel
2022-03-11 13:55 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 2/6] tst_test.sh: Redesing tst_mkfs() API Petr Vorel
2022-03-11 14:08 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 3/6] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars Petr Vorel
2022-02-11 6:58 ` xuyang2018.jy
2022-02-11 7:15 ` Petr Vorel
2022-03-11 14:28 ` Cyril Hrubis
2022-03-13 21:48 ` Petr Vorel
2022-02-10 16:27 ` [LTP] [PATCH v2 4/6] df01.sh: Use TST_FORMAT_DEVICE=1 Petr Vorel
2022-03-11 14:34 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 5/6] shell: Add test for TST_FORMAT_DEVICE=1 Petr Vorel
2022-02-11 5:17 ` xuyang2018.jy
2022-02-11 6:44 ` Petr Vorel
2022-03-11 14:36 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 6/6] doc: Add missing shell variables Petr Vorel
2022-02-11 6:28 ` xuyang2018.jy
2022-02-11 7:48 ` Petr Vorel [this message]
2022-03-11 14:43 ` Cyril Hrubis
2022-03-13 21:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgYU26YmOgFsr4o9@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox