From: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
To: Petr Vorel <pvorel@suse.cz>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2 3/6] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars
Date: Fri, 11 Feb 2022 06:58:47 +0000 [thread overview]
Message-ID: <62060952.5040909@fujitsu.com> (raw)
In-Reply-To: <20220210162739.30159-4-pvorel@suse.cz>
Hi Petr
> +
> +[source,sh]
> +-------------------------------------------------------------------------------
> +TST_FORMAT_DEVICE=1
> +TST_DEV_FS_OPTS="-b 1024 -O quota"
> +TST_DEV_EXTRA_OPTS="5m"
> +TST_TESTFUNC=test
> +
> +test1()
A small nit, I prefer to use test name directly if we don't have several
sub test cases.
Best Regards
Yang Xu
> +{
> + tst_res TPASS "device formatted"
> +}
> +-------------------------------------------------------------------------------
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-11 6:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 16:27 [LTP] [PATCH v2 0/6] Add TST_FORMAT_DEVICE support Petr Vorel
2022-02-10 16:27 ` [LTP] [PATCH v2 1/6] tst_test.sh: Properly init $TST_FS_TYPE Petr Vorel
2022-03-11 13:55 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 2/6] tst_test.sh: Redesing tst_mkfs() API Petr Vorel
2022-03-11 14:08 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 3/6] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars Petr Vorel
2022-02-11 6:58 ` xuyang2018.jy [this message]
2022-02-11 7:15 ` Petr Vorel
2022-03-11 14:28 ` Cyril Hrubis
2022-03-13 21:48 ` Petr Vorel
2022-02-10 16:27 ` [LTP] [PATCH v2 4/6] df01.sh: Use TST_FORMAT_DEVICE=1 Petr Vorel
2022-03-11 14:34 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 5/6] shell: Add test for TST_FORMAT_DEVICE=1 Petr Vorel
2022-02-11 5:17 ` xuyang2018.jy
2022-02-11 6:44 ` Petr Vorel
2022-03-11 14:36 ` Cyril Hrubis
2022-02-10 16:27 ` [LTP] [PATCH v2 6/6] doc: Add missing shell variables Petr Vorel
2022-02-11 6:28 ` xuyang2018.jy
2022-02-11 7:48 ` Petr Vorel
2022-03-11 14:43 ` Cyril Hrubis
2022-03-13 21:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62060952.5040909@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox