[LTP] [PATCH v3] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c

[LTP] [PATCH v3] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c

[Samir]

Fixed make check warning in cfs_bandwidth01.c to comply with LTP
coding style.

cfs_bandwidth01.c:
- Remove initialization of static variable to 0.

Patch v1: https://lore.kernel.org/ltp/20260407062336.127454-1-samir@linux.ibm.com/
Patch v2: https://lore.kernel.org/ltp/20260412122842.1074017-1-samir@linux.ibm.com/

Signed-off-by: Samir <samir@linux.ibm.com>
---
 testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c b/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c
index e52858f8e..8c511f060 100644
--- a/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c
+++ b/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c
@@ -35,7 +35,7 @@
 
 static struct tst_cg_group *cg_level2, *cg_level3a, *cg_level3b;
 static struct tst_cg_group *cg_workers[3];
-static int may_have_waiters = 0;
+static int may_have_waiters;
 
 static void set_cpu_quota(const struct tst_cg_group *const cg,
 			  const float quota_percent)
-- 
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c

[linuxtestproject.agent]

Hi Samir,

On Tue Jun  2 12:05:12 2026 +0200, Samir wrote:
> cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c

> -static int may_have_waiters = 0;
> +static int may_have_waiters;

All good. Reviewed.

Pre-existing issues noticed in the surrounding code (not introduced
by this patch):

- cfs_bandwidth01.c in do_test() -- sleep(1) and sleep(2) are used
  for process synchronization (waiting for workers to start and for
  throttling to take effect). Is there a checkpoint-based or
  polling-based approach that could replace these to avoid flakiness
  under load? The checkpoint mechanism is already used elsewhere in
  this test.

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c

[Andrea Cervesato via ltp]

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v3] cfs-scheduler: Fixed "make check" warning in cfs_bandwidth01.c

[Andrea Cervesato via ltp]

Merged, Thanks. I also fixed the commit message that was not
following the right conventions. Please make sure this will be
fixed the next time. In particular:

- commit subject was too long and verbose
- you added patch tracking into the commit message

Fixed into:

    cfs-scheduler: Fixed "make check" warning
    
    Fixed make check warning in cfs_bandwidth01.c to comply with LTP
    coding style.

Regards,
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp