From: sujiaxun <sujiaxun@uniontech.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix the 64-bit macro definition of mips architecture
Date: Mon, 26 Apr 2021 16:28:40 +0800 [thread overview]
Message-ID: <8aaa1c0e-e481-3c3e-c281-53aaf1bd499e@uniontech.com> (raw)
In-Reply-To: <20210426081219.tvaoqd67vj26bfr3@vireshk-i7>
? 2021/4/26 ??4:12, Viresh Kumar ??:
> On 26-04-21, 15:53, sujiaxun wrote:
>>
>>
>> On 2021/4/26 ??3:03, Viresh Kumar wrote:
>>> On 26-04-21, 15:00, sujiaxun wrote:
>>>> uos@uos-PC:~$ echo |gcc -dM -E - | grep -i arch
>>>> #define _MIPS_ARCH "mips64r2"
>>>> #define _MIPS_ARCH_MIPS64R2 1
>>>> uos@uos-PC:~$ echo |gcc -dM -E - | grep -i mips64
>>>> #define _MIPS_ISA _MIPS_ISA_MIPS64
>>>> #define _MIPS_TUNE "mips64r2"
>>>> #define _MIPS_TUNE_MIPS64R2 1
>>>> #define _MIPS_ARCH "mips64r2"
>>>> #define _MIPS_ARCH_MIPS64R2 1
>>>> #define __mips64 1
>>>> uos@uos-PC:~$ uname -m
>>>> mips64
>>>>
>>>> The mips architecture gcc has no built-in __arch64__, only __mips64
>>>> definitions. Of course, "__BITS_PER_LONG == 64" can also be used, but I
>>>> think it is better to use __mips64 in the mips architecture.
>>>
>>> Hmm, I will rather try to do what the kernel source code does, i.e.
>>> use __BITS_PER_LONG here instead.
>>>
>> I resubmitted a patch and changed "__arch64__" to "#if __BITS_PER_LONG ==
>> 64", the link is: https://patchwork.ozlabs.org/project/ltp/patch/20210426074812.27798-1-sujiaxun@uniontech.com
>
> You should have cc'd me directly :(
>
> I don't have that patch in my inbox..
>
> Though the patch looks fine.
>
Sorry, what should I do now?
next prev parent reply other threads:[~2021-04-26 8:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:26 [LTP] [PATCH] Fix the 64-bit macro definition of mips architecture sujiaxun
2021-04-26 5:42 ` Petr Vorel
2021-04-26 5:55 ` Viresh Kumar
2021-04-26 6:17 ` Petr Vorel
2021-04-26 6:23 ` Viresh Kumar
2021-04-26 7:00 ` sujiaxun
2021-04-26 7:03 ` Viresh Kumar
2021-04-26 7:53 ` sujiaxun
2021-04-26 8:12 ` Viresh Kumar
2021-04-26 8:28 ` sujiaxun [this message]
2021-04-26 8:44 ` Viresh Kumar
2021-04-26 13:09 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2021-04-26 7:48 sujiaxun
2021-04-26 9:00 ` sujiaxun
2021-04-26 9:02 ` Viresh Kumar
2021-04-27 12:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aaa1c0e-e481-3c3e-c281-53aaf1bd499e@uniontech.com \
--to=sujiaxun@uniontech.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox