From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix the 64-bit macro definition of mips architecture
Date: Mon, 26 Apr 2021 08:17:04 +0200 [thread overview]
Message-ID: <YIZa4Ph81LmkEkLZ@pevik> (raw)
In-Reply-To: <20210426055556.dmcogdykez2ddxn3@vireshk-i7>
Hi Viresh,
...
> > > -#if defined(__arch64__)
> > > +#if defined(__mips64)
> > So __arch64__ is not defined for mips 64 bit? (as it's defined for sparc 64bit?)
> > __mips64 is obviously correct and better readable, but is it really required?
> I am not sure what you meant by "is it really required?" The #ifdef hackery here
> ? It is as can be seen in include/uapi/asm-generic/shmbuf.h in Linux source.
I mean if #if defined(__mips__) && defined(__arch64__) detect 64bit mips
the patch would not be needed (although IMHO __mips64 is more descriptive than
__arch64__, for which you need to search for which architecture it was defined).
But I'm not sure myself if __arch64__ is defined for mips 64bit.
Kind regards,
Petr
next prev parent reply other threads:[~2021-04-26 6:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:26 [LTP] [PATCH] Fix the 64-bit macro definition of mips architecture sujiaxun
2021-04-26 5:42 ` Petr Vorel
2021-04-26 5:55 ` Viresh Kumar
2021-04-26 6:17 ` Petr Vorel [this message]
2021-04-26 6:23 ` Viresh Kumar
2021-04-26 7:00 ` sujiaxun
2021-04-26 7:03 ` Viresh Kumar
2021-04-26 7:53 ` sujiaxun
2021-04-26 8:12 ` Viresh Kumar
2021-04-26 8:28 ` sujiaxun
2021-04-26 8:44 ` Viresh Kumar
2021-04-26 13:09 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2021-04-26 7:48 sujiaxun
2021-04-26 9:00 ` sujiaxun
2021-04-26 9:02 ` Viresh Kumar
2021-04-27 12:32 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIZa4Ph81LmkEkLZ@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox