Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Fix the 64-bit macro definition of mips architecture
Date: Mon, 26 Apr 2021 07:42:36 +0200	[thread overview]
Message-ID: <YIZSzNd9uK8kItYb@pevik> (raw)
In-Reply-To: <20210422072609.9938-1-sujiaxun@uniontech.com>

Hi sujiaxun,

[ Cc: Viresh, the original author ]

> https://github.com/torvalds/linux/blob/master/arch/mips/include/uapi/asm/shmbuf.h
> The mips 64-bit macro definition in the kernel is "__mips64",
>  and the mips 64-bit macro definition in the ltp is "__arch64__".

> Signed-off-by: sujiaxun <sujiaxun@uniontech.com>
> ---
>  include/lapi/msgbuf.h | 2 +-
>  include/lapi/sembuf.h | 2 +-
>  include/lapi/shmbuf.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

> diff --git a/include/lapi/msgbuf.h b/include/lapi/msgbuf.h
> index f3277270d..f010695f1 100644
> --- a/include/lapi/msgbuf.h
> +++ b/include/lapi/msgbuf.h
> @@ -17,7 +17,7 @@
>  #if defined(__mips__)
>  #define HAVE_MSQID64_DS

> -#if defined(__arch64__)
> +#if defined(__mips64)
So __arch64__ is not defined for mips 64 bit? (as it's defined for sparc 64bit?)
__mips64 is obviously correct and better readable, but is it really required?
(you can check it with: echo | gcc -dM -E -).

Kind regards,
Petr

  reply	other threads:[~2021-04-26  5:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-22  7:26 [LTP] [PATCH] Fix the 64-bit macro definition of mips architecture sujiaxun
2021-04-26  5:42 ` Petr Vorel [this message]
2021-04-26  5:55   ` Viresh Kumar
2021-04-26  6:17     ` Petr Vorel
2021-04-26  6:23       ` Viresh Kumar
2021-04-26  7:00         ` sujiaxun
2021-04-26  7:03           ` Viresh Kumar
2021-04-26  7:53             ` sujiaxun
2021-04-26  8:12               ` Viresh Kumar
2021-04-26  8:28                 ` sujiaxun
2021-04-26  8:44                   ` Viresh Kumar
2021-04-26 13:09             ` Petr Vorel
  -- strict thread matches above, loose matches on Subject: below --
2021-04-26  7:48 sujiaxun
2021-04-26  9:00 ` sujiaxun
2021-04-26  9:02   ` Viresh Kumar
2021-04-27 12:32 ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIZSzNd9uK8kItYb@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox