public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/6] fzsync: Reset delay bias
Date: Mon, 8 Mar 2021 15:16:32 +0100	[thread overview]
Message-ID: <YEYxwOr3tOJdnz+j@yuki.lan> (raw)
In-Reply-To: <20210305155123.18199-3-rpalethorpe@suse.com>

Hi!
> If the delay bias a preserved then it breaks tests which have multiple
                    ^
		    is?

> scenarios and/or use -i. The test author could reset it manually in
> this case, but it's likely to be error prone.
>
> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>

Other than that this looks OK.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> ---
>  include/tst_fuzzy_sync.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/tst_fuzzy_sync.h b/include/tst_fuzzy_sync.h
> index 4141f5c64..b8841d96d 100644
> --- a/include/tst_fuzzy_sync.h
> +++ b/include/tst_fuzzy_sync.h
> @@ -289,6 +289,7 @@ static void tst_fzsync_pair_reset(struct tst_fzsync_pair *pair,
>  	tst_init_stat(&pair->diff_ab);
>  	tst_init_stat(&pair->spins_avg);
>  	pair->delay = 0;
> +	pair->delay_bias = 0;
>  	pair->sampling = pair->min_samples;
>  
>  	pair->exec_loop = 0;
> -- 
> 2.30.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-03-08 14:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 15:51 [LTP] [PATCH 0/6] Fuzzy Sync yielding and validation test Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 1/6] fzsync: Add self test Richard Palethorpe
2021-03-08 15:30   ` Cyril Hrubis
2021-03-08 16:18     ` Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 2/6] fzsync: Reset delay bias Richard Palethorpe
2021-03-08 14:16   ` Cyril Hrubis [this message]
2021-03-08 14:50     ` Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 3/6] fzsync: Correctly print positive lower delay range bound Richard Palethorpe
2021-03-08 14:18   ` Cyril Hrubis
2021-03-05 15:51 ` [LTP] [PATCH 4/6] fzsync: Add sched_yield for single core machine Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 5/6] fzsync: Move yield check out of loop and add yield to delay Richard Palethorpe
2021-03-08 11:32   ` Leo Liang
2021-03-08 14:48   ` Cyril Hrubis
2021-03-05 15:51 ` [LTP] [PATCH 6/6] fzsync: Check processor affinity Richard Palethorpe
2021-03-08 11:33   ` Leo Liang
2021-03-08 14:53   ` Cyril Hrubis
2021-03-08 15:30     ` Richard Palethorpe
2021-03-09 13:45 ` [LTP] [PATCH 0/6] Fuzzy Sync yielding and validation test Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEYxwOr3tOJdnz+j@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox