From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 0/6] Fuzzy Sync yielding and validation test
Date: Tue, 9 Mar 2021 14:45:20 +0100 [thread overview]
Message-ID: <YEd78LRleAgWNeN3@pevik> (raw)
In-Reply-To: <20210305155123.18199-1-rpalethorpe@suse.com>
Hi Richie,
1st patch has error:
tst_fuzzy_sync01.c: In function ?delay?:
tst_fuzzy_sync01.c:107:10: error: ?struct tst_fzsync_pair? has no member named ?yield_in_wait?
107 | if (pair.yield_in_wait)
| ^
tst_fuzzy_sync01.c:113:12: error: ?struct tst_fzsync_pair? has no member named ?yield_in_wait?
113 | if (pair.yield_in_wait)
| ^
make[1]: *** [../../include/mk/rules.mk:37: tst_fuzzy_sync01] Error 1
4th patch (Leo Yu-Chi Liang's) patch has warnings:
In file included from tst_fuzzy_sync01.c:8:
../../include/tst_fuzzy_sync.h: In function ?tst_fzsync_pair_init?:
../../include/tst_fuzzy_sync.h:199:18: warning: comparison of constant ?0? with boolean expression is always false [-Wbool-compare]
199 | if (pair->param < low) \
| ^
../../include/tst_fuzzy_sync.h:221:2: note: in expansion of macro ?CHK?
221 | CHK(yield_in_wait, 0, 1, (tst_ncpus() <= 1));
| ^~~
../../include/tst_fuzzy_sync.h:201:18: warning: comparison of constant ?1? with boolean expression is always false [-Wbool-compare]
201 | if (pair->param > hi) \
| ^
../../include/tst_fuzzy_sync.h:221:2: note: in expansion of macro ?CHK?
221 | CHK(yield_in_wait, 0, 1, (tst_ncpus() <= 1));
Apart from that whole patchset LGTM, agree with Cyril's suggestions.
Kind regards,
Petr
prev parent reply other threads:[~2021-03-09 13:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 15:51 [LTP] [PATCH 0/6] Fuzzy Sync yielding and validation test Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 1/6] fzsync: Add self test Richard Palethorpe
2021-03-08 15:30 ` Cyril Hrubis
2021-03-08 16:18 ` Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 2/6] fzsync: Reset delay bias Richard Palethorpe
2021-03-08 14:16 ` Cyril Hrubis
2021-03-08 14:50 ` Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 3/6] fzsync: Correctly print positive lower delay range bound Richard Palethorpe
2021-03-08 14:18 ` Cyril Hrubis
2021-03-05 15:51 ` [LTP] [PATCH 4/6] fzsync: Add sched_yield for single core machine Richard Palethorpe
2021-03-05 15:51 ` [LTP] [PATCH 5/6] fzsync: Move yield check out of loop and add yield to delay Richard Palethorpe
2021-03-08 11:32 ` Leo Liang
2021-03-08 14:48 ` Cyril Hrubis
2021-03-05 15:51 ` [LTP] [PATCH 6/6] fzsync: Check processor affinity Richard Palethorpe
2021-03-08 11:33 ` Leo Liang
2021-03-08 14:53 ` Cyril Hrubis
2021-03-08 15:30 ` Richard Palethorpe
2021-03-09 13:45 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEd78LRleAgWNeN3@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox