Re: [PATCH v2 mptcp-net 2/2] mptcp: zero window probe mib

[Paolo Abeni <pabeni@redhat.com>]

On 10/23/25 6:26 PM, Matthieu Baerts wrote:
> On 22/10/2025 09:39, Paolo Abeni wrote:
>> Explicitly account for MPTCP-level zero windows probe, to catch
>> hopefully earlier issues alike the one addressed by the previous
>> patch.
>>
>> Reviewed-by: Mat Martineau <martineau@kernel.org>
>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>> ---
>>  net/mptcp/mib.c      | 1 +
>>  net/mptcp/mib.h      | 1 +
>>  net/mptcp/protocol.c | 1 +
>>  3 files changed, 3 insertions(+)
>>
>> diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c
>> index 6003e47c770a7c..eb4645a9c5ac07 100644
>> --- a/net/mptcp/mib.c
>> +++ b/net/mptcp/mib.c
>> @@ -85,6 +85,7 @@ static const struct snmp_mib mptcp_snmp_list[] = {
>>  	SNMP_MIB_ITEM("DssFallback", MPTCP_MIB_DSSFALLBACK),
>>  	SNMP_MIB_ITEM("SimultConnectFallback", MPTCP_MIB_SIMULTCONNFALLBACK),
>>  	SNMP_MIB_ITEM("FallbackFailed", MPTCP_MIB_FALLBACKFAILED),
>> +	SNMP_MIB_ITEM("MPTcpWinProbe", MPTCP_MIB_MPTCPWINPROBE),
> 
> Detail: I just noticed that after having applied the patch: Do we need
> to double the 'MPTCP' keyword here? The full MIB counter name is:
> 
>   MPTcpExtMPTcpWinProbe
> 
> Maybe just WinProbe is enough? → MPTcpExtWinProbe

I'm sorry for the late reply. Yes WinProbe -> MPTcpExtWinProbe is the
correct/intended name, if you could fix that in the tree would be great,
thanks!

Paolo