Re: [PATCH v2 mptcp-net 0/2] mptcp: restore zero window probe

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 23/10/2025 08:24, Geliang Tang wrote:
> Hi Paolo,
> 
> On Wed, 2025-10-22 at 18:07 +0800, Geliang Tang wrote:
>> Hi Paolo,
>>
>> On Wed, 2025-10-22 at 09:39 +0200, Paolo Abeni wrote:
>>> It turns out that the issue reported by Geliang on the pending
>>> backlog
>>> patches is actually on older one that the new code made more easy
>>> reproducible.
>>>
>>> The first patch in the series addresses it[1], the 2nd one
>>> introduce
>>> new
>>> mibs to hopefully catch this problem sooned.
>>>
>>> I have a pktdrill to validate this scenario. I'll share that soon.
>>>
>>> @Geliang could you please validate the above in your testbed, on
>>> top
>>> of
>>> the backlog and splice patches?
>>
>> Thanks very much. I've already started testing, and so far everything
>> is running smoothly. I'll let it run loop tests overnight and will
>> have
>> the results by tomorrow morning. I'll provide you with feedback then.
> 
> Thank you so much! This fix really works. I've run hundreds of splice
> test loops with the following three patchsets applied, and no test
> failures occurred:
> 
> 	mptcp: restore zero window probe, v2
> 	mptcp: introduce backlog processing, v6
> 	implement mptcp read_sock, v13
> 
> Please add my tag for this set:
> 
> 	Reported-and-tested-by: Geliang Tang <geliang@kernel.org>

Thank you for the test!

To avoid issues with checkpatch and to be consistent, I'm going to add
this on the first patch:

  Reported-by: (...)
  Closes:
https://lore.kernel.org/d0a814c364e744ca6b836ccd5b6e9146882e8d42.camel@kernel.org
  (...)
  Tested-by: (...)

And only the Tested-by on the second one. I hope that's OK!

>> Thanks,
>> -Geliang
>>
>>>
>>> [1] at least here, at least with the packet drill reproducer ;)
>>> ---
>>> v1 -> v2:
>>>   - drop unneeded delta in patch 1/2
> 
> This change in v1 is valid. Later I will send a dedicated cleanup patch
> for -next to use tcp_sk() in mptcp_sendmsg_frag() with your "Suggested-
> by" tag.

Please only add such patch when we modify code around in net-next.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.