Re: [PATCH v2 mptcp-net 2/2] mptcp: zero window probe mib

[Matthieu Baerts <matttbe@kernel.org>]

Hi Paolo,

On 24/10/2025 09:30, Paolo Abeni wrote:
> On 10/23/25 6:26 PM, Matthieu Baerts wrote:
>> On 22/10/2025 09:39, Paolo Abeni wrote:
>>> Explicitly account for MPTCP-level zero windows probe, to catch
>>> hopefully earlier issues alike the one addressed by the previous
>>> patch.
>>>
>>> Reviewed-by: Mat Martineau <martineau@kernel.org>
>>> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>>> ---
>>>  net/mptcp/mib.c      | 1 +
>>>  net/mptcp/mib.h      | 1 +
>>>  net/mptcp/protocol.c | 1 +
>>>  3 files changed, 3 insertions(+)
>>>
>>> diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c
>>> index 6003e47c770a7c..eb4645a9c5ac07 100644
>>> --- a/net/mptcp/mib.c
>>> +++ b/net/mptcp/mib.c
>>> @@ -85,6 +85,7 @@ static const struct snmp_mib mptcp_snmp_list[] = {
>>>  	SNMP_MIB_ITEM("DssFallback", MPTCP_MIB_DSSFALLBACK),
>>>  	SNMP_MIB_ITEM("SimultConnectFallback", MPTCP_MIB_SIMULTCONNFALLBACK),
>>>  	SNMP_MIB_ITEM("FallbackFailed", MPTCP_MIB_FALLBACKFAILED),
>>> +	SNMP_MIB_ITEM("MPTcpWinProbe", MPTCP_MIB_MPTCPWINPROBE),
>>
>> Detail: I just noticed that after having applied the patch: Do we need
>> to double the 'MPTCP' keyword here? The full MIB counter name is:
>>
>>   MPTcpExtMPTcpWinProbe
>>
>> Maybe just WinProbe is enough? → MPTcpExtWinProbe
> 
> I'm sorry for the late reply. Yes WinProbe -> MPTcpExtWinProbe is the
> correct/intended name, if you could fix that in the tree would be great,
> thanks!

Thanks! Just did! I also renamed the enum

  MPTCP_MIB_MPTCPWINPROBE → MPTCP_MIB_WINPROBE:

New patches for t/upstream-net and t/upstream:
- 9525948cb5cc: Squash to "mptcp: zero window probe mib"
- Results: f6c0967d41d1..628a66ff3d17 (export-net)
- Results: 8416614a1e27..6354d0b32825 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/60ce52cf453b5182b993d2420d01422355ebbd67/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/a76c4725014b6c51385d301f1027a7891714a6bb/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.