Re: [PATCH mptcp-next 0/5] add helpers and vars in mptcp_lib.sh, part 2

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 19/02/2024 10:29, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Depends on:
>  - dump for userspace pm
>  - add helpers and vars in mptcp_lib.sh, part 1
> 
> Geliang Tang (5):
>   selftests: mptcp: unify namespace names to ns1/2/3/4
>   selftests: mptcp: add mptcp_lib_ns_* helpers
>   selftests: mptcp: add mptcp_lib_cleanup helper
>   selftests: mptcp: add mptcp_lib_check_output helper
>   selftests: mptcp: add mptcp_lib_evts_* helpers

Good idea to reduce duplicated code between selftests. Still, I think we
should not go "too far", and hide the use of some variables and files.
For example, I think it is important not to have hidden global
variables, or declare it on one file, and use it elsewhere (except if
they are prefixed with the name of the file: MPTCP_LIB_xxx).

Please see my comments on the individual patches.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.