Re: [PATCH mptcp-next 3/5] selftests: mptcp: add mptcp_lib_cleanup helper

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 19/02/2024 10:29, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This patch adds a new helper mptcp_lib_cleanup() in mptcp_lib.sh, it's
> a public cleanup interface, being invoked in every cleanup() in all
> scripts.

When looking at the commit alone, it is difficult to understand why it
is needed. In such cases, to help reviewers and dev later, please add
something like: This will be used in the next commit(s) for XXX.

(...)

> diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> index bfc535594675..01b0e43eaa80 100644
> --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> @@ -409,3 +409,7 @@ mptcp_lib_ns_exit() {
>  		i=$((i + 1))
>  	done
>  }
> +
> +mptcp_lib_cleanup() {
> +	echo "cleanup"

Do we want to print this everywhere?

> +}

(...)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.